summaryrefslogtreecommitdiff
path: root/util/libreboot-utils
AgeCommit message (Collapse)Author
82 min.libreboot-utils: extremely safe(ish) malloc usageHEADmasterLeah Rowe
yes, a common thing in C programs is one or all of the following: * use after frees * double free (on non-NULL pointer) * over-writing currently used pointer (mem leak) i try to reduce the chance of this in my software, by running free() through a filter function, free_if_not_null, that returns if a function is being freed twice - because it sets NULL after freeing, but will only free if it's not null already. this patch adds two functions: smalloc and vmalloc, for strings and voids. using these makes the program abort if: * non-null pointer given for initialisation * pointer to pointer is null (of course) * size of zero given, for malloc (zero bytes) i myself was caught out by this change, prompting me to make the following fix in fs_dirname_basename() inside lib/file.c: - char *buf; + char *buf = NULL; Yes. Signed-off-by: Leah Rowe <leah@libreboot.org>
3 hoursnvmutil: clamp rand (rejection sampling)Leah Rowe
clamp rand to eliminate modulo sampling; high values on the randomisation will bias the result. not really critical for mac addresses, but there's no reason not to have this. this patches reduces the chance that two libreboot users will generate the same mac addresses! Signed-off-by: Leah Rowe <leah@libreboot.org>
3 hoursutil/nvmutil: tidy up hextonumLeah Rowe
i had a bunch of hacks in here because i was previously using very buggy rand. now it's ok. Signed-off-by: Leah Rowe <leah@libreboot.org>
3 hoursrand.c: fix initialisation bug in mrkbufLeah Rowe
should be null on bad return Signed-off-by: Leah Rowe <leah@libreboot.org>
7 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
8 hoursheaderLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
13 hoursutil/libreboot-utils: fix div by zero in rsizeLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
13 hoursutil/libreboot-utils: finish implementing hellLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
27 hourschallengeLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
34 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
41 hoursfurther cleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
43 hourslibreboot-utils: improved randomness testLeah Rowe
and the module bias handling is fully correct Signed-off-by: Leah Rowe <leah@libreboot.org>
45 hoursmkhtemp rand: fix theoretical integer overflowLeah Rowe
extremely theoretical, with a T. T for theoretical. Signed-off-by: Leah Rowe <leah@libreboot.org>
45 hoursrand/libreboot/utils: prevent div by zeroLeah Rowe
not really a thing. bufsiz would never be zero, unless the demon takes over linux Signed-off-by: Leah Rowe <leah@libreboot.org>
45 hoursrand: fix modulo bias in rmallocLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursimprove 3Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursimprove 2Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursimproveLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursphrasingLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursnvmutil: remove errno handle in hextonumLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursREAL_POS_IO enable by default in nvmutilLeah Rowe
(for real pwrite/pread. don't use the compatibility one - it works perfectly, but using it is pointless and may have unknown bugs, even though i know it's probably perfect) Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursnvmutil: fix lseek call when read pos i/o enabledLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursmkhtemp readmeLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursmore cleanup on rand.cLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursfix makefileLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslibreboot-utils: tidy up rand.cLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslibreboot-utils: new function, scatn()Leah Rowe
concatenate an arbitrary number of strings, pointed to by char ** i'll use this and the next function, dcatn, in an upcoming feature planned for mkhtemp. Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursrmallocLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursutil/libreboot-utils: randomisation testLeah Rowe
to test the effectiveness of the rand function Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursmkrstrLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslbutils: new function, mkrbuf (random malloc)Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslbutils: close fd on rset failureLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursfurther clarify intenttLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslbutils, rset: err if zero bytes requestedLeah Rowe
similar to the logic about other failure states Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursdotLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslbutils: also check null!Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslbutils: clarify design regarding urandom/getrandomLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslbutils, rand: err on zero return (fatal)Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslbutils: cast to prevent ub in rset()Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hoursfix offset on urandom falbackLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslibreboot-utils: tidy up randLeah Rowe
make it more efficient. much lower rejection rate now, about 2-5%. deal with bias, but also get numbers in bulk. not too many. i'd say this is about right in terms of performance balance. 64 bytes == 8 large integers. Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourscleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslibreboot-utils: replace rlong() with rset()Leah Rowe
now you can send an arbitrary number of bytes with random numbers Signed-off-by: Leah Rowe <leah@libreboot.org>
47 hourslibreboot-utils: tidy up randLeah Rowe
also re-add /dev/urandom support, as a config option Signed-off-by: Leah Rowe <leah@libreboot.org>
generated by cgit v1.2.1 (git 2.18.0) at 2026-03-28 05:47:04 +0000