summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
53 min.util/nvmutil: fix bad cast conversionHEADmasterLeah Rowe
don't cast unsigned to signed. no behaviour is changed, but this will prevent some silly compilers complaining about -Wsign-conversion Signed-off-by: Leah Rowe <leah@libreboot.org>
57 min.util/nvmutil: add guard in rhex()Leah Rowe
i removed this before, but it's good to put it here defensively, in case i ever mess up the urandom read function again. Signed-off-by: Leah Rowe <leah@libreboot.org>
59 min.util/nvmutil: fix EINTR detection on urandom readLeah Rowe
i forgot to handle it in the previous refactor not really a problem in practise, since the first read probably succeeds anyway. Signed-off-by: Leah Rowe <leah@libreboot.org>
78 min.util/nvmutil: reorder some functions linearlyLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
84 min.util/nvmutil: tidy up gbe/urandom readingLeah Rowe
split them up into their own functions, since they no longer operate according to the same policy. Signed-off-by: Leah Rowe <leah@libreboot.org>
4 hoursutil/nvmutil: fix a bad commentLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
4 hoursutil/nvmutil: explicitly reset file descriptorsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
4 hoursutil/nvmutil: fix indentation in rhex()Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
4 hoursutil/nvmutil: remove unused variable in rhexLeah Rowe
on bsd Signed-off-by: Leah Rowe <leah@libreboot.org>
4 hoursutil/nvmutil: fix bsd build issueLeah Rowe
urandom_fd is unavailable on bsd Signed-off-by: Leah Rowe <leah@libreboot.org>
4 hoursutil/nvmutil: even safer rhex()Leah Rowe
also handles possible overflows in read_gbe_file_exact it removes dead code on both paths: arc4random and urandom Signed-off-by: Leah Rowe <leah@libreboot.org>
5 hoursutil/nvmutil: only check n in rhex on linuxLeah Rowe
not bsd Signed-off-by: Leah Rowe <leah@libreboot.org>
5 hoursutil/nvmutil: safer calculated_checksumLeah Rowe
we rely on uint16_t wrapping, but some platforms may behave weirdly. cast as uint32_t and then cast back, on return, with an explicit mask beforehand. Signed-off-by: Leah Rowe <leah@libreboot.org>
5 hoursutil/nvmutil: much safer rhex()Leah Rowe
n could be zero under weird regression cases Signed-off-by: Leah Rowe <leah@libreboot.org>
5 hoursutil/nvmutil: tidy up hexdump()Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
5 hoursutil/nvmutil: assert uint16_t as 16-bitsLeah Rowe
some platforms might get this wrong. define it explicitly. Signed-off-by: Leah Rowe <leah@libreboot.org>
5 hoursutil/nvmutil: safer cast in nvm_wordLeah Rowe
cast buf[x] directly. Signed-off-by: Leah Rowe <leah@libreboot.org>
6 hoursutil/nvmutil: define _FILE_OFFSET_BITSLeah Rowe
some older systems have 32-bit off_t. this makes them have 64-bit off_t Signed-off-by: Leah Rowe <leah@libreboot.org>
6 hoursutil/nvmutil: include sys/types.hLeah Rowe
some older systems need it for pread/pwrite it must come before stat.h Signed-off-by: Leah Rowe <leah@libreboot.org>
6 hoursutil/nvmutil: use even older define for preadLeah Rowe
with this new define, we can target even older systems from the late 90s. Signed-off-by: Leah Rowe <leah@libreboot.org>
7 hoursutil/nvmutil: tidied up a commentLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
7 hoursutil/nvmutil: don't include not-needed inttypes.hLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
7 hoursutil/nvmutil: reset errno on urandom partial readLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
7 hoursutil/nvmutil: consistent file location on err()Leah Rowe
put it at the start of the message Signed-off-by: Leah Rowe <leah@libreboot.org>
7 hoursmove nvmutil .gitignore rules to util/nvmutil/Leah Rowe
i plan to release this as a standalone utility at some point, once it's perfect (on its current feature set) Signed-off-by: Leah Rowe <leah@libreboot.org>
7 hoursutil/nvmutil: remove empty ChangeLog/READMELeah Rowe
i will write a *manpage* at some point. for now, the documentation on libreboot.org shall suffice. i'm nearly ready to submit this code to coreboot. Signed-off-by: Leah Rowe <leah@libreboot.org>
8 hoursutil/nvmutil: clean up the MakefileLeah Rowe
that option there is already defined in the code Signed-off-by: Leah Rowe <leah@libreboot.org>
8 hoursutil/nvmutil: tidy up the main comment headerLeah Rowe
merge it into one Signed-off-by: Leah Rowe <leah@libreboot.org>
15 hoursutil/nvmutil: say what the program does!Leah Rowe
and with this, i'm probably done for a while i've obsessively audited this code for a week Signed-off-by: Leah Rowe <leah@libreboot.org>
15 hoursutil/nvmutil: standardised Makefile (add all)Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
15 hoursutil/nvmutil: Makefile cleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
16 hoursutil/nvmutil: add phone section to MakefileLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
16 hoursutil/nvmutil: safer / more portable installLeah Rowe
explicitly declare the directory path for the given file (nvmutil), otherwise it's implementation-defined; on some systems, /bin/nvmutil means a directory named nvmutil could then contain nvmutil. Signed-off-by: Leah Rowe <leah@libreboot.org>
16 hoursutil/nvmutil: create install dir in MakefileLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
16 hoursutil/nvmutil: fix target in MakefileLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
16 hoursutil/nvmutil: directly compare fd/urandom_fdLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
16 hoursutil/nvmutil: allow partial reads of /dev/urandomLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
17 hoursutil/nvmutil: explicit cast in nvm_wordLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
17 hoursutil/nvmutil: clarify CFLAGS in codeLeah Rowe
makefile is correct, but lots of people don't read it. putting it iin code helps people avoid confusion. Signed-off-by: Leah Rowe <leah@libreboot.org>
17 hoursutil/nvmutil: specifically enable -std=c99Leah Rowe
I also needed: #define _POSIX_C_SOURCE 200809L I use -pedantic with -Wall -Wextra -Werror, which forces very strict error handling and ISO C; this means pread and pwrite aren't available. The define fixes this. Signed-off-by: Leah Rowe <leah@libreboot.org>
17 hoursutil/nvmutil: fix indentation in setmacLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
18 hoursutil/nvmutil: err sooner, on bad commandLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
18 hoursutil/nvmutil: print expected checksumsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
19 hoursutil/nvmutil: rename cmd helper functionsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
19 hoursutil/nvmutil: remove MAC address short-commandsLeah Rowe
only allow the long form: setmac [MAC] specifying gbe.bin just shows the help/usage now. this is a safety feature, so that someone doesn't accidentally write the gbe file. we want it to be that the user specifically requested setmac. setmac with mac address as the 3rd argument is also disabled. this is done as part of a general simplification and safety improvement to nvmutil. Signed-off-by: Leah Rowe <leah@libreboot.org>
20 hoursutil/nvmutil: remove cmd_brickLeah Rowe
this is an extremely dangerous feature, and serves no purpose to the user. this change is part of a series of extreme safety improvements, part of a larger nvmutil audit. Signed-off-by: Leah Rowe <leah@libreboot.org>
20 hoursutil/nvmutil: remove the setchecksum commandLeah Rowe
This feature is extremely dangerous, and we should discourage against its use. This is part of a series of changes that I've made to make the code safer. You should only ever run this on a valid GbE file, and nothing else. Signed-off-by: Leah Rowe <leah@libreboot.org>
20 hoursutil/nvmutil: re-order functions by executionLeah Rowe
linear, top-down order. re-order the prototypes also some general cleanup: argc enums now validated. ifdefs for pledge and arc4random now use a consistent naming scheme. feature change: the "dump" command now fails if both checksums are invalid, and won't show anything. my next commit will disable setchecksum when both checksums are invalid. this and the other insane auditing i've done over the last few days has been part of a major effort to make nvmutil extremely safe, and robust. Signed-off-by: Leah Rowe <leah@libreboot.org>
21 hoursutil/nvmutil: unified checksum updateLeah Rowe
setchecksum and setmac update the checksum. other commands don't. this patch unified the logic, handling it in write_gbe based on command[].chksum_write Signed-off-by: Leah Rowe <leah@libreboot.org>
22 hoursutil/nvmutil: don't pledge on OLD openbsdLeah Rowe
only pledge/unveil where available, on versions that have it. this patch disables it on older versions, allowing nvmutil to compile. Signed-off-by: Leah Rowe <leah@libreboot.org>
generated by cgit v1.2.1 (git 2.18.0) at 2026-03-09 22:05:32 +0000