summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2026-03-10 01:51:18 +0000
committerLeah Rowe <leah@libreboot.org>2026-03-10 01:51:18 +0000
commit0c23474322218ec64c73c647efdc6679f6119955 (patch)
tree6e5f1952fb9d90bb1ec82331ab2f3d977125fca2
parent84a9e8f89bbc0e3d52641e54f26978ac9ae19607 (diff)
util/nvmutil: report checksum in cmd_dump
as it should be! Signed-off-by: Leah Rowe <leah@libreboot.org>
-rw-r--r--util/nvmutil/nvmutil.c13
1 files changed, 10 insertions, 3 deletions
diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c
index 7ddb8322..b6570d42 100644
--- a/util/nvmutil/nvmutil.c
+++ b/util/nvmutil/nvmutil.c
@@ -1041,12 +1041,19 @@ cmd_helper_dump(void)
{
size_t partnum;
- int errval = good_checksum(0);
- errval |= good_checksum(1);
- if (errval)
+ part_valid[0] = good_checksum(0);
+ part_valid[1] = good_checksum(1);
+
+ if (part_valid[0] || part_valid[1])
errno = 0;
for (partnum = 0; partnum < 2; partnum++) {
+ if (!part_valid[partnum])
+ fprintf(stderr,
+ "BAD checksum %04x in part %zu (expected %04x)\n",
+ nvm_word(NVM_CHECKSUM_WORD, partnum),
+ partnum, calculated_checksum(partnum));
+
printf("MAC (part %zu): ", partnum);
print_mac_from_nvm(partnum);
hexdump(partnum);