summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2026-03-10 01:38:22 +0000
committerLeah Rowe <leah@libreboot.org>2026-03-10 01:38:22 +0000
commit84a9e8f89bbc0e3d52641e54f26978ac9ae19607 (patch)
treea0441a82db6661331446ca5231d3feba1d9596ad
parent007dece09e6ad84aee02a8fb78193075252050ee (diff)
util/nvmutil: reduce checksum report verbosity
only print a message what arg_part is set. this means that a checksum error message won't be printed on cat commands. Signed-off-by: Leah Rowe <leah@libreboot.org>
-rw-r--r--util/nvmutil/nvmutil.c18
1 files changed, 5 insertions, 13 deletions
diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c
index bd3dd304..7ddb8322 100644
--- a/util/nvmutil/nvmutil.c
+++ b/util/nvmutil/nvmutil.c
@@ -785,9 +785,13 @@ read_checksums(void)
if (num_invalid < max_invalid)
errno = 0;
- if (num_invalid >= max_invalid)
+ if (num_invalid >= max_invalid) {
+ if (max_invalid == 1)
+ err(ECANCELED, "%s: part %zu has a bad checksum",
+ fname, part);
err(ECANCELED, "%s: No valid checksum found in file",
fname);
+ }
}
static int
@@ -796,21 +800,9 @@ good_checksum(size_t partnum)
uint16_t expected_checksum = calculated_checksum(partnum);
uint16_t current_checksum = nvm_word(NVM_CHECKSUM_WORD, partnum);
- size_t real_partnum = partnum ^ command[cmd_index].invert;
-
if (current_checksum == expected_checksum)
return 1;
- fprintf(stderr,
- "WARNING: BAD checksum in part %zu\n"
- "EXPECTED checksum in part %zu: %04x\n"
- "CURRENT checksum in part %zu: %04x\n",
- real_partnum,
- real_partnum,
- expected_checksum,
- real_partnum,
- current_checksum);
-
set_err(ECANCELED);
return 0;
}