summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-18build: reduce code to less than 80 chars per lineLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18blobutil: exit 1 if a called script failsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18blobutil: cleaner coding styleLeah Rowe
reduced indentation main() on top top-down logic Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: exit 1 if unsupported argument givenLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: use subshells where appropriateLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: re-add redirection to /dev/nullLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck clean: clean coreboot directories tooLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: reduce indentation level for loopLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: move logic out of main()Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: *actually* check coreboot directoriesLeah Rowe
2023-05-18.gitcheck: improved coding styleLeah Rowe
main() on top top-down order of logic Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: check argv when running gitcheck-cleanLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18.gitcheck: actually *run* gitcheck-cleanLeah Rowe
Run() is called, but without argument. This patch fixes that. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18download: code cleanupLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18download: check for non-existent script in loopLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18download script: bugfix: gitcheck clean didn't runLeah Rowe
the "placeholder" git credentials were not being wiped, which sometimes overwrites the user's git credentials permanently, when working on lbmk (permanently, until manually reset by the user) Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18download script: improved coding styleLeah Rowe
introduce main() cleaned up the if/else block Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Use pledge but only on OpenBSDLeah Rowe
It will only be used on OpenBSD. Other operating systems will behave in the same way. Pledge is feature specific to OpenBSD that restricts system operations, for security: https://man.openbsd.org/pledge.2 Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Add -u flag (no line buffer)Leah Rowe
printf outputs to stdout, which is line buffered by default. Adding a -u option to disable buffering. Exit when a non-support flag is given, but adhere to current behaviour when no flag is given. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Tidy up global variablesLeah Rowe
They do not need to be initialised zero, because global variables are always zero by default, unless set differently by the programmer. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Make pulse variable globalLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Use parentheses on comparisonsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Move global variable: pulseLeah Rowe
It is only used by a single function. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Purge unused global: amplitudeLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Remove unused variable: posLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Re-order functions for clarityLeah Rowe
print_char() is referenced last, so declare it last. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Handle output in new functionLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Re-order prototypesLeah Rowe
Put them in the same order as declared. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Rename functions for clarityLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Return errno in mainLeah Rowe
This is a good general practise, to catch errors. Any errors found can then be handled in code. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Use correct printf specifierLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Add error handlingLeah Rowe
There was literally no error handling before. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Move logic out of mainLeah Rowe
Main should only be a skeletal structure. Actual logic should always be handled externally. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Rename variable for clarityLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Remove use of static keywordLeah Rowe
It is entirely superfluous in this program. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Rename variable for clarityLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Remove space in function callsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Say frame in EnglishLeah Rowe
Source code should be written in English. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Top-down logic (main on top)Leah Rowe
Add the appropriate prototype. Top-down function order is easier to read. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: simplified pulse checkLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Define argc/argv in mainLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Reduced indentation in loopLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Use tabs for indentationLeah Rowe
The GNU indentation style is hard to read. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Add clean to the MakefileLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Define CC in the MakefileLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Add strict CFLAGSLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-16util/spkmodem_recv: Import from corebootLeah Rowe
Imported from util/spkmodem_recv at coreboot revision: e70bc423f9a2e1d13827f2703efe1f9c72549f20 This is a client for spkmodem, to allow serial console via PC speaker. I've decided to import it in lbmk, because I heavily modified it. The patches will be applied next. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-15download/coreboot: minor code cleanupLeah Rowe
i'm pretty much finished now there might be a few more changes later, like stricter error handling, more verbose error messages, etc right now, it relies on -e to kill lbmk on error, and uses the exit command another planned change it to support other upstreams besides coreboot.org, such as the dasharo codebase the latter is *why* i refactored this download script, for asus kgped-d16
2023-05-15download/coreboot: remove errant codeLeah Rowe
the build_error file is obsolete
2023-05-15download/coreboot: tidy up variable namesLeah Rowe