diff options
| author | Leah Rowe <leah@libreboot.org> | 2026-04-01 17:27:18 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2026-04-01 17:29:28 +0100 |
| commit | c48a962eaf4d2033465a01c83c98caeca7b5a5fd (patch) | |
| tree | b45377f58b985aa7cf2139f1f5badf0bb95f7bb9 /util/libreboot-utils/lib | |
| parent | 3d24aa98f9a38dc246afbf1fb23d3b99b03bea2b (diff) | |
lbutils/file: fix overflow check
clang -Weverything:
lib/file.c:165:49: warning: implicit conversion changes signedness: 'ssize_t' (aka 'long') to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
165 | if (if_err(rval >= 0 && (size_t)rval > (nrw - rc), EOVERFLOW))
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'util/libreboot-utils/lib')
| -rw-r--r-- | util/libreboot-utils/lib/file.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/util/libreboot-utils/lib/file.c b/util/libreboot-utils/lib/file.c index 883d4cd4..3ec39239 100644 --- a/util/libreboot-utils/lib/file.c +++ b/util/libreboot-utils/lib/file.c @@ -158,7 +158,8 @@ rw_exact(int fd, unsigned char *mem, size_t nrw, while (1) { /* Prevent theoretical overflow */ - if (if_err(rval >= 0 && (size_t)rval > (nrw - rc), EOVERFLOW)) + if (if_err(rval >= 0 && (size_t)rval > (nrw - (size_t)rc), + EOVERFLOW)) goto err_rw_exact; rc += rval; |