diff options
| author | Leah Rowe <leah@libreboot.org> | 2026-04-01 06:10:57 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2026-04-01 06:10:57 +0100 |
| commit | f90af15502dbcd4c3fb8df66b77f869d005978cd (patch) | |
| tree | 561503e1d5380ba7409401d8346d52fe7893f038 /util/libreboot-utils/lib/mkhtemp.c | |
| parent | e731893208cd6e2401a2171672e6928b05947e3f (diff) | |
safer macro
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'util/libreboot-utils/lib/mkhtemp.c')
| -rw-r--r-- | util/libreboot-utils/lib/mkhtemp.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/util/libreboot-utils/lib/mkhtemp.c b/util/libreboot-utils/lib/mkhtemp.c index c1574634..7d1a02f3 100644 --- a/util/libreboot-utils/lib/mkhtemp.c +++ b/util/libreboot-utils/lib/mkhtemp.c @@ -699,6 +699,10 @@ mkhtemp_tmpfile_linux(int dirfd, linked = 1; /* file created */ + /* TODO: potential fd leak here. + * probably should only set *fd on successful + * return from this function (see below) + */ if (fd_verify_dir_identity(dirfd, st_dir_first) < 0 || fstat(*fd = tmpfd, st) < 0 || secure_file(fd, st, st, O_APPEND, 1, 1, 0600) < 0) |