summaryrefslogtreecommitdiff
path: root/script/vendor/download
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-12-24 09:04:36 +0000
committerLeah Rowe <leah@libreboot.org>2023-12-24 09:04:36 +0000
commit0aca6332ee5865dbf4717235cbf9f5e8e79dddc3 (patch)
treecbb2a18ec22213208ab3dcaf22eebbb84fb14e5e /script/vendor/download
parent575332f2219c9e6f435b7ed35bfb2a408de0628c (diff)
lbmk scripts: shorter code lines
while seemingly pedantic, this does actually make code easier to read. mostly just switching to shorthand for variable names, where no expansions or patterns are used Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/vendor/download')
-rwxr-xr-xscript/vendor/download30
1 files changed, 15 insertions, 15 deletions
diff --git a/script/vendor/download b/script/vendor/download
index 25434318..1f96c665 100755
--- a/script/vendor/download
+++ b/script/vendor/download
@@ -30,7 +30,7 @@ main()
[ $# -gt 0 ] || err "No argument given"
board="${1}"
boarddir="${cbcfgsdir}/${board}"
- _b="${board%%_*mb}" # shorthand (avoid duplicating config per rom size)
+ _b="${board%%_*mb}" # shorthand (no duplication per rom size)
check_defconfig "${boarddir}" && exit 0
detect_firmware && exit 0
@@ -162,28 +162,28 @@ extract_intel_me()
[ -f "${_me}" ] && return 0
sdir="$(mktemp -d)"
- mkdir -p "${sdir}" || err "extract_intel_me: !mkdir -p \"${sdir}\""
+ mkdir -p "$sdir" || err "extract_intel_me: !mkdir -p \"$sdir\""
(
- [ "${cdir#/a}" != "${cdir}" ] && cdir="${cdir#/}"
- cd "${cdir}" || err "extract_intel_me: !cd \"${cdir}\""
+ [ "${cdir#/a}" != "$cdir" ] && cdir="${cdir#/}"
+ cd "$cdir" || err "extract_intel_me: !cd \"$cdir\""
for i in *; do
- [ -f "${_me}" ] && break
- [ -L "${i}" ] && continue
- if [ -f "${i}" ]; then
- "${mecleaner}" -r -t -O "${sdir}/vendorfile" \
- -M "${_me}" "${i}" && break
- "${mecleaner}" -r -t -O "${_me}" "${i}" && break
- "${me7updateparser}" -O "${_me}" "${i}" && break
+ [ -f "$_me" ] && break
+ [ -L "$i" ] && continue
+ if [ -f "$i" ]; then
+ "$mecleaner" -r -t -O "${sdir}/vendorfile" \
+ -M "$_me" "$i" && break
+ "$mecleaner" -r -t -O "$_me" "$i" && break
+ "$me7updateparser" -O "$_me" "$i" && break
_7ztest="${_7ztest}a"
- extract_archive "${i}" "${_7ztest}" || continue
- extract_intel_me "${_me}" "${cdir}/${_7ztest}"
+ extract_archive "$i" "$_7ztest" || continue
+ extract_intel_me "$_me" "${cdir}/${_7ztest}"
elif [ -d "$i" ]; then
- extract_intel_me "${_me}" "${cdir}/${i}"
+ extract_intel_me "$_me" "${cdir}/${i}"
else
continue
fi
cdir="${1}"
- [ "${cdir#/a}" != "${cdir}" ] && cdir="${cdir#/}"
+ [ "${cdir#/a}" != "$cdir" ] && cdir="${cdir#/}"
cd "${cdir}" || :
done
)