summaryrefslogtreecommitdiff
path: root/script/update/vendor
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-10-07 05:36:52 +0100
committerLeah Rowe <leah@libreboot.org>2023-10-07 05:37:11 +0100
commit4708da2ca9a72520f39749b3b34b0bdc2fbfa15d (patch)
tree8c7f436fc53d10665f150e295d2d488b3f86e729 /script/update/vendor
parent0fad3497b82d9225468835d1b27717050ca6de46 (diff)
use quotes when checking empty strings in scripts
this is far less error-prone Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/update/vendor')
-rwxr-xr-xscript/update/vendor/inject6
1 files changed, 3 insertions, 3 deletions
diff --git a/script/update/vendor/inject b/script/update/vendor/inject
index 0b26f81e..846f1846 100755
--- a/script/update/vendor/inject
+++ b/script/update/vendor/inject
@@ -41,7 +41,7 @@ check_board()
if ! check_release "${archive}" ; then
[ -f "${rom}" ] || \
err "check_board: \"${rom}\" is not a valid path"
- [ -z ${rom+x} ] && \
+ [ -z "${rom+x}" ] && \
err "check_board: no rom specified"
[ ! -z ${board+x} ] || \
board=$(detect_board "${rom}")
@@ -214,7 +214,7 @@ inject_vendorfile_intel_me()
printf "adding intel me firmware\n"
rom="${1}"
- [ -z ${CONFIG_ME_BIN_PATH} ] && \
+ [ -z "${CONFIG_ME_BIN_PATH}" ] && \
err "inject_vendorfile_intel_me: CONFIG_ME_BIN_PATH not set"
_me_location=${CONFIG_ME_BIN_PATH##*../}
@@ -282,7 +282,7 @@ inject_vendorfile_smsc_sch5545_ec()
modify_gbe()
{
printf "changing mac address in gbe to ${new_mac}\n"
- [ -z ${CONFIG_GBE_BIN_PATH} ] && \
+ [ -z "${CONFIG_GBE_BIN_PATH}" ] && \
err "modify_gbe: ${board}: CONFIG_GBE_BIN_PATH not set"
rom="${1}"