summaryrefslogtreecommitdiff
path: root/script/roms
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2024-06-17 01:05:28 +0100
committerLeah Rowe <leah@libreboot.org>2024-06-17 01:05:28 +0100
commitf928ac5c702c4ed4afc638ca8bdd8bd1d1d4a685 (patch)
tree5f7632990bd70e15fa19799d61656b4b6420cfea /script/roms
parent58a451865b199261efcceb7db319a8c6f714301a (diff)
roms: rename x variable to it in for loopaudit6-merge1
there are two for loops that use x as a variable anme, and an idiosyncrasy of certain sh implementations is that these become global; the result in this case was that when you finish building every target in "./build roms", it would print "libgfxinit" repeatedly, comma separated, instead of a comma-separated list of the targets that were built. work around it by renaming the variable in one of the loops. Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/roms')
-rwxr-xr-xscript/roms4
1 files changed, 2 insertions, 2 deletions
diff --git a/script/roms b/script/roms
index e002c40f..3412b150 100755
--- a/script/roms
+++ b/script/roms
@@ -173,8 +173,8 @@ build_board()
{
x_ rm -Rf "$romdir"
- for x in "normal" "vgarom" "libgfxinit"; do
- initmode="$x"
+ for it in "normal" "vgarom" "libgfxinit"; do
+ initmode="$it"
hmode="vesafb"
[ "$initmode" = "vgarom" ] || hmode="corebootfb"
modes="$hmode txtmode"