diff options
| author | Leah Rowe <leah@libreboot.org> | 2023-12-24 09:04:36 +0000 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2023-12-24 09:04:36 +0000 |
| commit | 0aca6332ee5865dbf4717235cbf9f5e8e79dddc3 (patch) | |
| tree | cbb2a18ec22213208ab3dcaf22eebbb84fb14e5e /script/build/serprog | |
| parent | 575332f2219c9e6f435b7ed35bfb2a408de0628c (diff) | |
lbmk scripts: shorter code lines
while seemingly pedantic, this does actually make code
easier to read. mostly just switching to shorthand for
variable names, where no expansions or patterns are used
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/serprog')
| -rwxr-xr-x | script/build/serprog | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/script/build/serprog b/script/build/serprog index c961161a..28cd70a4 100755 --- a/script/build/serprog +++ b/script/build/serprog @@ -18,7 +18,7 @@ usage="usage: ./build firmware serprog <rp2040|stm32> [board]" main() { [ -z "${1+x}" ] && err "${usage}" - [ "${1}" != "rp2040" ] && [ "${1}" != "stm32" ] && err "${usage}" + [ "$1" != "rp2040" ] && [ "$1" != "stm32" ] && err "$usage" if [ "${1}" = "rp2040" ]; then boards_dir=${pico_sdk_dir}/src/boards/include/boards [ -d "$pico_src_dir" ] || x_ ./update trees -f "pico-serprog" @@ -44,23 +44,23 @@ build_rp2040_rom() { board=${1} printf "Building pico-serprog for %s\n" "${board}" - x_ cmake -DPICO_BOARD="${board}" -DPICO_SDK_PATH="${pico_sdk_dir}" \ + x_ cmake -DPICO_BOARD="$board" -DPICO_SDK_PATH="$pico_sdk_dir" \ -B "${pico_src_dir}/build" "${pico_src_dir}" x_ cmake --build "${pico_src_dir}/build" x_ mv ${pico_src_dir}/build/pico_serprog.uf2 \ bin/serprog_rp2040/serprog_${board}.uf2 - printf "output to bin/serprog_rp2040/serprog_%s.uf2\n" "${board}" + printf "output to bin/serprog_rp2040/serprog_%s.uf2\n" "$board" } build_stm32_rom() { board=${1} printf "Building stm32-vserprog for %s\n" "${board}" - x_ make -C ${stm32_src_dir} libopencm3-just-make BOARD=${board} + x_ make -C $stm32_src_dir libopencm3-just-make BOARD=$board x_ make -C ${stm32_src_dir} BOARD=${board} x_ mv ${stm32_src_dir}/stm32-vserprog.hex \ bin/serprog_stm32/serprog_${board}.hex - printf "output to bin/serprog_stm32/serprog_%s.hex\n" "${board}" + printf "output to bin/serprog_stm32/serprog_%s.hex\n" "$board" } print_boards() |