diff options
author | Leah Rowe <leah@libreboot.org> | 2025-05-16 08:20:17 +0100 |
---|---|---|
committer | Leah Rowe <leah@libreboot.org> | 2025-05-16 09:44:34 +0100 |
commit | 6a2ed9428b7528da5c3953a89797d9bfb6d8f7f3 (patch) | |
tree | e4e362844e2c4958a6b6c49b2e76008aeccdc1be /script/build/rpi-pico/serprog | |
parent | 4313b474a593c5b2e57278c590b7cfb56dec5114 (diff) |
On release archives, I overlooked the previous change to
downloads, during the recent implementation of extra safety
checks. I previously checked there whether the variable named
CONFIG_KBC1126_FIRMWARE was defined, and grabbed both; now I
check CONFIG_KBC1126_FW1 and CONFIG_KBC1126_FW2 separately,
grabbing each file separately.
This patch replicates that change for insertions. Otherwise,
hash verification on ROM images will fail, when running the
inject script on release images.
Downloading was being done, reliably, and the extracted files
were correct, so there was no danger if the user was building
from source and flashing that way.
However, checksum verification on full images failed when
inserting into archives. This is not because the files were
wrong; they were *correct*. However, the EC firmware was not
being inserted *at all* on HP EliteBooks, because of this
oversight. The check is now based on whether the paths to
the files themselves are defined, not whether EC firmware
is enabled in the coreboot config; the latter is implied.
With this patch, vendor file insertion once again works
perfectly, without error, on every board. There was no real
danger for users, just a minor inconvenience. Sorry!
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/rpi-pico/serprog')
0 files changed, 0 insertions, 0 deletions