diff options
| author | Leah Rowe <leah@libreboot.org> | 2023-12-16 07:56:26 +0000 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2023-12-16 07:56:26 +0000 |
| commit | 1eb4df6748f94a08d44c623a56417199b99b371d (patch) | |
| tree | e45f8b519cfe1e22dda8ef18763f8ae3546c477f /script/build/roms | |
| parent | 54ca5f24d20531ac728a9475a94912f0a08f29f7 (diff) | |
fix several shellcheck warnings
lbmk didn't quote certain arguments in commands, or
used ! -z instead of -n, things like that. simple fixes.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/roms')
| -rwxr-xr-x | script/build/roms | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/script/build/roms b/script/build/roms index a96ad89b..c1bca851 100755 --- a/script/build/roms +++ b/script/build/roms @@ -64,7 +64,7 @@ main() [ -z "${targets}" ] && err "No ROM images were compiled" printf "\nROM images available in these directories:\n" - printf "${targets}^^ ROM images available in these directories.\n\n" + printf "%s^^ ROM images available in these directories.\n\n" "${targets}" printf "DO NOT flash ROM images from elf/ - please use bin/ instead.\n" } @@ -230,7 +230,7 @@ build_roms() _cbrom="elf/coreboot_nopayload_DO_NOT_FLASH/${board}/${initmode}_${displaymode}" [ "${initmode}" = "normal" ] && \ - _cbrom="${_cbrom%_${displaymode}}" + _cbrom="${_cbrom%"_${displaymode}"}" _cbrom="${_cbrom}/coreboot.rom" cbrom="$(mktemp -t coreboot_rom.XXXXXXXXXX)" x_ cp "${_cbrom}" "${cbrom}" @@ -349,7 +349,7 @@ mkSeabiosRom() { x_ cp "${_cbrom}" "${tmprom}" x_ "${cbfstool}" "${tmprom}" add-payload -f "${_seabioself}" \ - -n ${_seabios_cbfs_path} -c lzma + -n "${_seabios_cbfs_path}" -c lzma x_ "${cbfstool}" "${tmprom}" add-int -i 3000 -n etc/ps2-keyboard-spinup z="2"; [ "${initmode}" = "vgarom" ] && z="0" @@ -405,7 +405,7 @@ mkUbootRom() { x_ cp "${_cbrom}" "${tmprom}" x_ "${cbfstool}" "${tmprom}" add-payload -f "${_ubootelf}" \ - -n ${_uboot_cbfs_path} -c lzma + -n "${_uboot_cbfs_path}" -c lzma printf "%s\n" "${tmprom}" } |