diff options
author | Leah Rowe <leah@libreboot.org> | 2025-04-29 11:16:30 +0100 |
---|---|---|
committer | Leah Rowe <leah@libreboot.org> | 2025-04-29 11:25:39 +0100 |
commit | da108d1c045582af0b81ca05c758125071155f03 (patch) | |
tree | 863f7b32b29edb63122ebc1ab08eba16947c1ffa /script/build/command/options | |
parent | 71a58a38ab4eca90894c65dbfd188a62380637cc (diff) |
mk: Don't run mkhelpers if mode is set
If the mode string is empty, then it's a build command.
See commit:
commit b1ea4165754f04660d3c7282274c4b12355f88a0
Author: Leah Rowe <leah@libreboot.org>
Date: Wed Apr 23 03:54:08 2025 +0100
mk: remove mkhelp() and use x_() instead
This commit removed the following check:
If mode isn't set, run an mkhelper, otherwise don't.
Because this simplification removed that behaviour,
running e.g. "./mk -m coreboot x200_8mb" would result
in the mkcorebootbin function being executed, which is
normally putting the coreboot rom together.
Since it wasn't built in this case, an error is thrown.
This change therefore restores the previous behaviour,
fixing the bug.
First reported in this error report:
https://codeberg.org/libreboot/lbmk/issues/306
This commit fixes the issue.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/command/options')
0 files changed, 0 insertions, 0 deletions