diff options
| author | Leah Rowe <leah@libreboot.org> | 2023-10-01 02:12:42 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2023-10-01 04:08:30 +0100 |
| commit | 92c6da7b210d760693d2f36c457ea96eeaf8d7a2 (patch) | |
| tree | 9949d89109809bf7c5566ca7512a9ebbcd74efd3 /script/build/boot/roms | |
| parent | 2a6fcf7022d1ca3abc6f65438cf5bd93aac2a100 (diff) | |
build/boot/roms_helper: shorten variable names
also: further reduce the number of arguments passed,
to certain functions as and when feasible, in cases
where those are global variables that never change.
the cbfstool argument in mkUbootRom wasn't even used.
that function was only using the global variable, which
again is only set once.
i also shortened a few messages, removed a few errant
line breaks and reduced sloccount by exactly 1 in main()
by re-arranging how the shift command is used.
it's mainly about shortening variable names, to then
reduce the number of line breaks, but it's a surgical
code size reduction in build/boot/roms.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/boot/roms')
| -rwxr-xr-x | script/build/boot/roms | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/script/build/boot/roms b/script/build/boot/roms index 39c0eed6..29f53dda 100755 --- a/script/build/boot/roms +++ b/script/build/boot/roms @@ -21,8 +21,7 @@ handle_targets() { [ -z "${_displaymode}" ] || _displaymode="-d ${_displaymode}" [ -z "${_payload}" ] || _payload="-p ${_payload}" - [ -z "${_keyboard_layout}" ] || \ - _keyboard_layout="-k ${_keyboard_layout}" + [ -z "${_keyboard}" ] || _keyboard="-k ${_keyboard}" printf "Building %s ROM images\n" "${projectname}" @@ -44,10 +43,9 @@ check_targets() build_bootroms() { - opts="${_displaymode} ${_payload} ${_keyboard_layout}" + opts="${_displaymode} ${_payload} ${_keyboard}" for x in ${boards}; do - ./build boot roms_helper ${_displaymode} ${_payload} \ - ${_keyboard_layout} ${x} || \ + ./build boot roms_helper ${opts} ${x} || \ err "handle_targets ${opts} ${x}: build error" [ -d "bin/${x}" ] && targets="${x} ${targets}" done |