diff options
author | Leah Rowe <leah@libreboot.org> | 2024-12-24 13:33:20 +0000 |
---|---|---|
committer | Leah Rowe <leah@libreboot.org> | 2024-12-24 14:09:29 +0000 |
commit | 5d1f1823067d81867ab226a4d0e7c515e6a56e6a (patch) | |
tree | 194b225f998ca108d2473b4be5c42ba636209b04 /resources/coreboot/kgpe-d16-udimm_8mb | |
parent | a18175a5df960e0098945e8be0f3f7fd275c07a1 (diff) |
vendor.sh: Safer exit when vendorfiles not needed
When vendor files were not needed on a given board,
the script would directly exit. This is bad, because
the inject functions are called directly from the main
script, which means the parent instance of lbmk.
This means that the lock file and temporary files were
not being removed on exit. On a subsequent run, this
would cause the error stating that a lock file is present,
which would cause further error, making the user believe
something is broken in lbmk.
Modify the behaviour accordingly; exits are now returns,
and these are handled in the calling functions, in such
a way that a proper exit occurs, whereby temporary files
and the lock file are deleted.
For context, please read the main "build" script where
it calls vendor_inject and vendor_download. At the end
of that script, it calls tmp_cleanup, which removes the
TMPDIR that was created, and the lock file. In lbmk,
the TMPDIR is not /tmp, but rather a subdirectory
under /tmp, so that further calls to mktemp create
everything under one single temporary directory, which
lbmk automatically removes on exit.
Therefore, this patch also avoids leaving temporary files
laying around on the disk.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'resources/coreboot/kgpe-d16-udimm_8mb')
0 files changed, 0 insertions, 0 deletions