summaryrefslogtreecommitdiff
path: root/include/rom.sh
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2025-10-04 02:43:24 +0100
committerLeah Rowe <leah@libreboot.org>2025-10-04 02:43:24 +0100
commit0605fbe72032125c8b430f1454794be40ab61009 (patch)
tree54f2c020a8b3a09f1c84c930680924e90dfb5ccd /include/rom.sh
parente1c70f43198e7d709026ab7cd0422adc24083bd4 (diff)
xbmk: general cleanup: unroll condensed code lines
i overlooked a number of lines, during previous cleanup Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'include/rom.sh')
-rw-r--r--include/rom.sh16
1 files changed, 9 insertions, 7 deletions
diff --git a/include/rom.sh b/include/rom.sh
index 2dd16c70..0edd5e89 100644
--- a/include/rom.sh
+++ b/include/rom.sh
@@ -12,11 +12,11 @@ buildser()
{
if [ "$1" = "pico" ]; then
x_ cmake -DPICO_BOARD="$2" \
- -DPICO_SDK_PATH="$picosdk" -B "$sersrc/build" "$sersrc" && \
- x_ cmake --build "$sersrc/build"
+ -DPICO_SDK_PATH="$picosdk" -B "$sersrc/build" "$sersrc"
+ x_ cmake --build "$sersrc/build"
elif [ "$1" = "stm32" ]; then
- x_ make -C "$sersrc" libopencm3-just-make \
- BOARD=$2 && x_ make -C "$sersrc" BOARD=$2
+ x_ make -C "$sersrc" libopencm3-just-make BOARD=$2
+ x_ make -C "$sersrc" BOARD=$2
fi
x_ mkdir -p "bin/serprog_$1"
@@ -106,6 +106,7 @@ check_coreboot_util()
# TODO: is this rm command needed?
x_ rm -Rf "$utilelfdir"
+
return 0
elif [ -n "$mode" ] || [ -f "$utilelfdir/$1" ]; then
return 0
@@ -341,12 +342,13 @@ mkseagrub()
add_uboot()
{
if [ "$displaymode" = "txtmode" ]; then
- printf "cb/%s: Cannot use U-Boot in text mode\n" \
- "$target" 1>&2
+ printf "cb/%s: Can't use U-Boot in text mode\n" "$target" 1>&2
+
return 0
elif [ "$initmode" = "normal" ]; then
- printf "cb/%s: Cannot use U-Boot in normal initmode\n" \
+ printf "cb/%s: Can't use U-Boot in normal initmode\n" \
"$target" 1>&2
+
return 0
fi