diff options
| author | Leah Rowe <leah@libreboot.org> | 2025-09-24 13:19:23 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2025-09-24 13:19:23 +0100 |
| commit | 8347e2c85da0841dd35d6f94a5b3cf14bd1adff0 (patch) | |
| tree | 1b0a5cd08058e8824e036d7f41f9246a4724175d /include/mrc.sh | |
| parent | 03bf6c185b96e631d0f52a67b685628514b3776c (diff) | |
xbmk: cleanup of recent code refactoring
be a bit less pedantic about if else clauses. leave the
big ones still with then on separate lines, where else
is specified.
also unroll a few condensed code lines where i missed
a few.
sloccount 2303 in lbmk. that's still only slightly bigger
than libreboot 20260907 which was 2180, and still much
smaller than libreboot 20230625 which was 3322.
this is *without* the condensed codelines, so now the only
thing that's reduced is the overall amount of logic present
in the build system.
and i should clarify that lbmk is presently much more powerful
than both of those two versions (20160907/20230625).
the 2016 one is useful for comparison historically, since that
was the last major version of libreboot prior to the great
second coming of leah in 2021; and the 2023 june release was
basically the last one before the great audits of 2023 to
2025 began.
not to brag (not much anyway), but all of this means that lbmk
is an insanely efficient build system, considering all the
features it has and what it does.
i unrolled the condensed code style in lbmk, making the scripts
a lot easier to read, because i received complainst about the
condensed style previously used; nicholas chin and alper nebi
yasak both told me that it sucked, and riku viitanen had hinted
at that same fact several months prior.
so hopefully now, lbmk is a bit nicer. those and other people
often find it challenging to challenge me because for reason
they assume i'll get upset and fly off the handle, but it's the
opposite. i want constant criticism, so that i know to improve!
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'include/mrc.sh')
| -rw-r--r-- | include/mrc.sh | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/include/mrc.sh b/include/mrc.sh index 4e749b4b..7dba6263 100644 --- a/include/mrc.sh +++ b/include/mrc.sh @@ -21,8 +21,7 @@ extract_refcode() -m x86 -n fallback/refcode -f "$appdir/ref" -r RO_SECTION # enable the Intel GbE device, if told by offset MRC_refcode_gbe - if [ -n "$MRC_refcode_gbe" ] - then + if [ -n "$MRC_refcode_gbe" ]; then x_ dd if="config/ifd/hp820g2/1.bin" of="$appdir/ref" bs=1 \ seek=$MRC_refcode_gbe count=1 conv=notrunc; : fi @@ -36,7 +35,6 @@ extract_mrc() SHELLBALL="chromeos-firmwareupdate-$MRC_board" ( - x_ cd "$appdir" extract_partition "${MRC_url##*/}" extract_archive "$SHELLBALL" . |