diff options
| author | Leah Rowe <leah@libreboot.org> | 2025-10-04 06:13:15 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2025-10-04 07:17:42 +0100 |
| commit | 4f01dc704a1ed0e18fc0efc1500e61b4bc41b0e6 (patch) | |
| tree | 5f6045ed1662614ad75c9eb46be3867937640450 /include/mrc.sh | |
| parent | 7f8d85140fd229e97e539ca463fbd94545997fd6 (diff) | |
xbmk: remove even more eval statements
in one or two cases, the use of eval is retained, but
modified so as to be safer.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'include/mrc.sh')
| -rw-r--r-- | include/mrc.sh | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/include/mrc.sh b/include/mrc.sh index d2249aeb..92241b22 100644 --- a/include/mrc.sh +++ b/include/mrc.sh @@ -18,7 +18,10 @@ extract_refcode() # and refcode is extracted from an image using the old scheme. we use # cbfstool from coreboot 4.11_branch, the tree used by ASUS KGPE-D16: - chkvars cbfstoolref + if [ -z "$cbfstoolref" ]; then + err "cbfstoolref not set" "extract_refcode" "$@" + fi + x_ mkdir -p "${_pre_dest%/*}" x_ "$cbfstoolref" "$appdir/bios.bin" extract \ @@ -35,7 +38,12 @@ extract_refcode() extract_mrc() { - chkvars "MRC_board" "CONFIG_MRC_FILE" + if [ -z "$MRC_board" ]; then + err "MRC_board unset" "extract_mrc" "$@" + elif [ -z "$CONFIG_MRC_FILE" ]; then + err "CONFIG_MRC_FILE unset" "extract_mrc" "$@" + fi + SHELLBALL="chromeos-firmwareupdate-$MRC_board" ( |