summaryrefslogtreecommitdiff
path: root/config/coreboot/default/patches/0030-src-intel-skylake-Disable-stack-overflow-debug-optio.patch
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2026-04-23 23:14:25 +0100
committerLeah Rowe <leah@libreboot.org>2026-04-23 23:14:25 +0100
commitf60350344a56fa2b9db2b0653f69a7b036da8aab (patch)
treeeb8c11369829054eb0ebe5339f0025ab6a8409e5 /config/coreboot/default/patches/0030-src-intel-skylake-Disable-stack-overflow-debug-optio.patch
parent2ecfe63b5f96331d4d7b8afbee07ba9dbd69ef5d (diff)
consolidate haswell iommu patchesHEADmaster
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'config/coreboot/default/patches/0030-src-intel-skylake-Disable-stack-overflow-debug-optio.patch')
-rw-r--r--config/coreboot/default/patches/0030-src-intel-skylake-Disable-stack-overflow-debug-optio.patch61
1 files changed, 0 insertions, 61 deletions
diff --git a/config/coreboot/default/patches/0030-src-intel-skylake-Disable-stack-overflow-debug-optio.patch b/config/coreboot/default/patches/0030-src-intel-skylake-Disable-stack-overflow-debug-optio.patch
deleted file mode 100644
index 695a03a7..00000000
--- a/config/coreboot/default/patches/0030-src-intel-skylake-Disable-stack-overflow-debug-optio.patch
+++ /dev/null
@@ -1,61 +0,0 @@
-From 7c4df892425e076b1d2768f9b99362f58e7872dc Mon Sep 17 00:00:00 2001
-From: Leah Rowe <leah@libreboot.org>
-Date: Mon, 6 Jan 2025 01:36:23 +0000
-Subject: [PATCH 30/51] src/intel/skylake: Disable stack overflow debug options
-
-The option was appearing in T480/3050micro configs of lbmk,
-after updating on the coreboot/next uprev for 20241206 rev8:
-
-CONFIG_DEBUG_STACK_OVERFLOW_BREAKPOINTS=y
-
-I did some digging. See coreboot commit:
-
-commit 51cc2bacb6b07279b97e9934d079060475481fb6
-Author: Subrata Banik <subratabanik@google.com>
-Date: Fri Dec 13 13:07:28 2024 +0530
-
- soc/intel/pantherlake: Disable stack overflow debug options
-
-Well now:
-
-I'm disabling this behaviour on Skylake, for the same
-behaviour, because I want as few behaviour changes in general,
-as possible, for the rev8 release.
-
-According to Subrata's patch, which was for Pantherlake,
-without this change, stack corruption can occur on verstage
-and romstage early on. Please look at that coreboot patch,
-referenced above, for clarity.
-
-I see no harm in disabling this option for Skylake, since
-the behaviour that it otherwise enables was not present
-before.
-
-Signed-off-by: Leah Rowe <leah@libreboot.org>
----
- src/soc/intel/skylake/Kconfig | 9 +++++++++
- 1 file changed, 9 insertions(+)
-
-diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
-index c76239936a..f8ff8cfa7a 100644
---- a/src/soc/intel/skylake/Kconfig
-+++ b/src/soc/intel/skylake/Kconfig
-@@ -136,6 +136,15 @@ config DCACHE_RAM_SIZE
- The size of the cache-as-ram region required during bootblock
- and/or romstage.
-
-+# Override DEBUG Kconfig to avoid false alarm about stack overflow.
-+config DEBUG_STACK_OVERFLOW_BREAKPOINTS
-+ bool
-+ default n
-+
-+config DEBUG_STACK_OVERFLOW_BREAKPOINTS_IN_ALL_STAGES
-+ bool
-+ default n
-+
- config DCACHE_BSP_STACK_SIZE
- hex
- default 0x20400 if FSP_USES_CB_STACK
---
-2.47.3
-