diff options
author | Leah Rowe <leah@libreboot.org> | 2024-12-30 00:50:53 +0000 |
---|---|---|
committer | Leah Rowe <leah@libreboot.org> | 2024-12-30 01:02:22 +0000 |
commit | e565df94fd7a6a4fb2b6a51c3cd938825c66390e (patch) | |
tree | cd8367ed4146962695bf82ced4ec76ba1dc116df /build | |
parent | c80cc0a00b6fbe5e94bb35c5760e224ce70c09f0 (diff) |
Fix globbing issue in lbmk
When doing e.g. $@ we should use double quotes to prevent globbing.
Thanks go to XRevan86 for pointing this out.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'build')
-rwxr-xr-x | build | 12 |
1 files changed, 6 insertions, 6 deletions
@@ -32,16 +32,16 @@ main() case "${spath#script/}" in version) printf "%s\nWebsite: %s\n" "$relname" "$projectsite" ;; - release) shift 1; mkrelease $@ ;; - inject) shift 1; vendor_inject $@ ;; - download) shift 1; vendor_download $@ ;; + release) shift 1; mkrelease "$@" ;; + inject) shift 1; vendor_inject "$@" ;; + download) shift 1; vendor_download "$@" ;; roms) [ $# -gt 1 ] && [ "$2" = "serprog" ] && \ mk -b stm32-vserprog pico-serprog && return 0 - shift 1; x_ ./mk -b coreboot $@ ;; + shift 1; x_ ./mk -b coreboot "$@" ;; *) [ -f "$spath" ] || $err "bad command" - $shcmd; "$spath" $@ || $err "excmd: $spath $(echo "$@")" ;; + $shcmd; "$spath" "$@" || $err "excmd: $spath $(echo "$@")" ;; esac set -u -e # some commands disable them. turn them on! } @@ -128,5 +128,5 @@ tmp_cleanup() rm -f lock || return 1 } -main $@ +main "$@" tmp_cleanup || err_ "can't rm TMPDIR upon non-zero exit: $TMPDIR" |