diff options
| author | Leah Rowe <leah@libreboot.org> | 2025-10-04 02:55:52 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2025-10-04 02:55:52 +0100 |
| commit | a09ec1d02b275fa0d79a0a21be77d450fd86318b (patch) | |
| tree | 7787b7d6f288bbf3cd8da35e6962d88e95216b23 | |
| parent | 0605fbe72032125c8b430f1454794be40ab61009 (diff) | |
xbmk: remove more eval statements
i will eventually find a way to remove them all,
while still leaving the code completely clean.
in practise, i never use the contents of a file
for eval and the inputs are carefully checked.
however, over-use of eval is always a bad idea
in shell scripting.
Signed-off-by: Leah Rowe <leah@libreboot.org>
| -rw-r--r-- | include/get.sh | 19 | ||||
| -rw-r--r-- | include/release.sh | 6 |
2 files changed, 20 insertions, 5 deletions
diff --git a/include/get.sh b/include/get.sh index 20cf7c90..db61958b 100644 --- a/include/get.sh +++ b/include/get.sh @@ -3,8 +3,15 @@ # Copyright (c) 2020-2021,2023-2025 Leah Rowe <leah@libreboot.org> # Copyright (c) 2022 Caleb La Grange <thonkpeasant@protonmail.com> -eval "`setvars "" loc url bkup_url subcurl subhash subgit subgit_bkup \ - depend subcurl_bkup`" +depend="" +loc="" +url="" +bkup_url="" +subgit="" +subgit_bkup="" +subcurl="" +subcurl_bkup="" +subhash="" tmpgit="$xbtmp/gitclone" tmpgitcache="$xbtmp/tmpgit" @@ -76,8 +83,12 @@ fetch_submodule() { mcfgdir="$mdir/${1##*/}" - eval \ - "`setvars "" subhash subgit subgit_bkup subcurl subcurl_bkup st`" + subhash="" + subgit="" + subgit_bkup="" + subcurl="" + subcurl_bkup="" + st="" eval "`setcfg "$mcfgdir/module.cfg" 0`" diff --git a/include/release.sh b/include/release.sh index f1783dcf..a2eb28a6 100644 --- a/include/release.sh +++ b/include/release.sh @@ -2,7 +2,11 @@ # Copyright (c) 2023-2025 Leah Rowe <leah@libreboot.org> -eval "`setvars "" reldir reldest vdir rsrc relmode`" +reldir="" +reldest="" +vdir="" +rsrc="" +relmode="" release() { |