diff options
| author | Leah Rowe <leah@libreboot.org> | 2025-10-06 13:28:34 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2025-10-06 13:28:34 +0100 |
| commit | 8636d7497cb455ac15407e737b479180186996ee (patch) | |
| tree | ba18fc11a901c2e314c90c00aacca0d8d725f3e2 | |
| parent | 1b54c7a744ac474bdcf0844ace97741b949a6fa1 (diff) | |
the way it was used is messy, and a relic of the
old chained command coding style, from before when
i recently loosened that requirement.
the new focus is simple, readable code, regardless
of size.
Signed-off-by: Leah Rowe <leah@libreboot.org>
| -rw-r--r-- | include/rom.sh | 32 | ||||
| -rw-r--r-- | include/tree.sh | 34 |
2 files changed, 35 insertions, 31 deletions
diff --git a/include/rom.sh b/include/rom.sh index 67723559..8cb0f318 100644 --- a/include/rom.sh +++ b/include/rom.sh @@ -233,26 +233,25 @@ mkcorebootbin_real() payload_grubsea="n" fi + $if_dry_build \ + return 0 + if [ -f "$cbfscfg" ]; then - $if_not_dry_build \ - dx_ add_cbfs_option "$cbfscfg" + dx_ add_cbfs_option "$cbfscfg" fi - if $if_not_dry_build grep "CONFIG_PAYLOAD_NONE=y" "$defconfig"; then + if grep "CONFIG_PAYLOAD_NONE=y" "$defconfig"; then if [ "$payload_seabios" = "y" ]; then pname="seabios" - $if_not_dry_build \ - add_seabios + add_seabios fi if [ "$payload_uboot" = "arm64" ]; then pname="uboot" - $if_not_dry_build \ - add_uboot + add_uboot fi else pname="custom" - $if_not_dry_build \ - cprom + cprom fi; : } @@ -502,13 +501,14 @@ cbfs() mkcoreboottar() { - if [ "$target" != "$tree" ] && [ "$XBMK_RELEASE" = "y" ] && \ - [ "$release" != "n" ]; then - - $if_not_dry_build \ - mkrom_tarball "bin/$target" + $if_dry_build \ + return 0 - $if_not_dry_build \ - x_ ./mk inject "bin/${relname}_${target}.tar.xz" nuke + if [ "$target" = "$tree" ] || [ "$XBMK_RELEASE" != "y" ] || \ + [ "$release" = "n" ]; then + return 0 fi + + mkrom_tarball "bin/$target" + x_ ./mk inject "bin/${relname}_${target}.tar.xz" nuke } diff --git a/include/tree.sh b/include/tree.sh index 7b5d57b5..cb406233 100644 --- a/include/tree.sh +++ b/include/tree.sh @@ -240,9 +240,10 @@ handle_defconfig() if [ -z "$mode" ]; then for _xarch in $xarch; do + $if_dry_build \ + break if [ -n "$_xarch" ]; then - $if_not_dry_build \ - check_cross_compiler "$_xarch" + check_cross_compiler "$_xarch" fi done; : fi @@ -629,7 +630,9 @@ check_defconfig() # skip build if a previous one exists: - if ! $if_not_dry_build elfcheck; then + $if_dry_build \ + return 0 + if ! elfcheck; then return 1 fi } @@ -701,25 +704,26 @@ run_make_command() fi if [ "$mode" = "clean" ]; then - $if_not_dry_build \ - make -C "$srcdir" $cleanargs distclean || \ - $if_not_dry_build \ - x_ make -C "$srcdir" $cleanargs clean; : + $if_dry_build \ + return 0 + if ! make -C "$srcdir" $cleanargs distclean; then + x_ make -C "$srcdir" $cleanargs clean + fi fi } check_cmake() { - if [ -n "$cmakedir" ]; then - if ! $if_not_dry_build check_makefile "$1"; then - if ! cmake -B "$1" "$1/$cmakedir"; then - $if_not_dry_build \ - x_ check_makefile "$1" - fi + $if_dry_build \ + return 0 + if [ ! -n "$cmakedir" ]; then + return 0 + elif ! check_makefile "$1"; then + if ! cmake -B "$1" "$1/$cmakedir"; then + x_ check_makefile "$1" fi - $if_not_dry_build \ - x_ check_makefile "$1"; : fi + x_ check_makefile "$1"; : } check_autoconf() |