diff options
| author | Leah Rowe <leah@libreboot.org> | 2026-03-09 21:12:59 +0000 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2026-03-09 21:12:59 +0000 |
| commit | 45ea92a077bf7a822f0562b10652e98431fe3ce4 (patch) | |
| tree | 505e7fd98ceeb4466a22eab506d63741467ac712 | |
| parent | b5af1bf3acac1383ab23efec05c847851fcce130 (diff) | |
util/nvmutil: fix bad cast conversion
don't cast unsigned to signed.
no behaviour is changed, but this will prevent some
silly compilers complaining about -Wsign-conversion
Signed-off-by: Leah Rowe <leah@libreboot.org>
| -rw-r--r-- | util/nvmutil/nvmutil.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index 314d4755..37959bd2 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -683,14 +683,16 @@ read_gbe_file(void) static void read_gbe_file_part(size_t p) { - size_t gbe_rw_size = command[cmd_index].rw_size; + ssize_t rc; + size_t gbe_rw_size = command[cmd_index].rw_size; void *mem_offset = gbe_mem_offset(p ^ command[cmd_index].invert, "pread"); - if ((size_t)read_gbe_file_exact(gbe_fd, mem_offset, - gbe_rw_size, gbe_file_offset(p, "pread")) != - gbe_rw_size) + rc = read_gbe_file_exact(gbe_fd, mem_offset, + gbe_rw_size, gbe_file_offset(p, "pread")); + + if (rc != (ssize_t)gbe_rw_size) err(ECANCELED, "%s: Partial read from p%zu", fname, p); printf("%s: Read %zu bytes from p%zu\n", |