diff options
| author | Leah Rowe <leah@libreboot.org> | 2024-12-10 23:45:59 +0000 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2024-12-10 23:48:41 +0000 |
| commit | c2023921893f8ee11a9a611469bb8350ef1692be (patch) | |
| tree | c8737d16558ba28a82fe1f9c7ec3b84d9d688576 | |
| parent | da527459b68f2e7a1e6a902fdb5b7d89e8b69dd6 (diff) | |
fix t480 spd size (512, not 256)
this was done with the following command:
./mk -u coreboot t480s_fsp_16mb t480_fsp_16mb
it was set to 256 but should be 512. the SPD is what
contains configuration data for raminit, which training
code uses so that the timings will be correct. if the SPD
size is wrong, the machine won't boot
in practise, lbmk always runs "make oldconfig" on
a coreboot config, before building it, so this was
already being corrected automatically at build time.
however, if that fact ever changes in the future, this
wrong configuration would cause the machines not to boot.
therefore, this can be considered a preventative or perhaps
pre-emptive bug fix.
this fix does not need to be applied to the 20241206 release,
because of the behaviour described above. the final ROM images
do have the spd size set correctly to 512, because of this
design feature in lbmk.
Signed-off-by: Leah Rowe <leah@libreboot.org>
4 files changed, 4 insertions, 4 deletions
diff --git a/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb b/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb index 2be0ecec..769d53eb 100644 --- a/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb +++ b/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" diff --git a/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode b/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode index 95989094..e21749fe 100644 --- a/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode +++ b/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" diff --git a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb index 8d33544d..9eb3bf31 100644 --- a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb +++ b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" diff --git a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode index 8714de3e..9bd3bcdd 100644 --- a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode +++ b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" |