From c2023921893f8ee11a9a611469bb8350ef1692be Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Tue, 10 Dec 2024 23:45:59 +0000 Subject: fix t480 spd size (512, not 256) this was done with the following command: ./mk -u coreboot t480s_fsp_16mb t480_fsp_16mb it was set to 256 but should be 512. the SPD is what contains configuration data for raminit, which training code uses so that the timings will be correct. if the SPD size is wrong, the machine won't boot in practise, lbmk always runs "make oldconfig" on a coreboot config, before building it, so this was already being corrected automatically at build time. however, if that fact ever changes in the future, this wrong configuration would cause the machines not to boot. therefore, this can be considered a preventative or perhaps pre-emptive bug fix. this fix does not need to be applied to the 20241206 release, because of the behaviour described above. the final ROM images do have the spd size set correctly to 512, because of this design feature in lbmk. Signed-off-by: Leah Rowe --- config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb | 2 +- config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode | 2 +- config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb | 2 +- config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb b/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb index 2be0ecec..769d53eb 100644 --- a/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb +++ b/config/coreboot/t480_fsp_16mb/config/libgfxinit_corebootfb @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" diff --git a/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode b/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode index 95989094..e21749fe 100644 --- a/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode +++ b/config/coreboot/t480_fsp_16mb/config/libgfxinit_txtmode @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" diff --git a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb index 8d33544d..9eb3bf31 100644 --- a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb +++ b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_corebootfb @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" diff --git a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode index 8714de3e..9bd3bcdd 100644 --- a/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode +++ b/config/coreboot/t480s_fsp_16mb/config/libgfxinit_txtmode @@ -115,7 +115,7 @@ CONFIG_MAINBOARD_VERSION="1.0" CONFIG_MAINBOARD_DIR="lenovo/sklkbl_thinkpad" CONFIG_VGA_BIOS_ID="8086,0406" CONFIG_DIMM_MAX=2 -CONFIG_DIMM_SPD_SIZE=256 +CONFIG_DIMM_SPD_SIZE=512 CONFIG_FMDFILE="" # CONFIG_NO_POST is not set CONFIG_MAINBOARD_VENDOR="LENOVO" -- cgit v1.2.1