diff options
| author | Leah Rowe <leah@libreboot.org> | 2024-05-29 03:23:30 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2024-05-29 03:25:33 +0100 |
| commit | 47f582d4639d4b9079aa83cba95681c5ebbaad3b (patch) | |
| tree | 31fd5968ea3d6ed8155534a550112fc0abf1a186 | |
| parent | e7cb10d68b46bd4efb9a87c36d337f8a4fe1e24c (diff) | |
./vendor download: skip if blob path is /dev/null
We use a path of /dev/null pointing to a ROM for
Fam15h AMD boards, to add fake PIKE2008 images.
This is to mitigate a hang in SeaBIOS, but now with
recent changes, this causes the command below to
download coreboot, when it should just exit saying
no vendor files needed. Prevent accidentally wasted
bandwidth. The command was:
./vendor download kcma_d8_rdimm_16mb
This now correctly does the following:
$ ./vendor download kcma_d8_rdimm_16mb
Vendor files not needed for: kcma_d8_rdimm_16mb
The joys of programming a build system in sh!
Signed-off-by: Leah Rowe <leah@libreboot.org>
| -rwxr-xr-x | include/vendor.sh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/vendor.sh b/include/vendor.sh index 8178fbf9..f307fcbd 100755 --- a/include/vendor.sh +++ b/include/vendor.sh @@ -62,6 +62,7 @@ detect_firmware() for c in CONFIG_HAVE_MRC CONFIG_HAVE_ME_BIN CONFIG_KBC1126_FIRMWARE \ CONFIG_VGA_BIOS_FILE CONFIG_INCLUDE_SMSC_SCH5545_EC_FW; do + eval "[ \"\${$c}\" = \"/dev/null\" ] && continue" eval "[ -z \"\${$c}\" ] || return 1" done printf "Vendor files not needed for: %s\n" "$board" 1>&2 |