From 47f582d4639d4b9079aa83cba95681c5ebbaad3b Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Wed, 29 May 2024 03:23:30 +0100 Subject: ./vendor download: skip if blob path is /dev/null We use a path of /dev/null pointing to a ROM for Fam15h AMD boards, to add fake PIKE2008 images. This is to mitigate a hang in SeaBIOS, but now with recent changes, this causes the command below to download coreboot, when it should just exit saying no vendor files needed. Prevent accidentally wasted bandwidth. The command was: ./vendor download kcma_d8_rdimm_16mb This now correctly does the following: $ ./vendor download kcma_d8_rdimm_16mb Vendor files not needed for: kcma_d8_rdimm_16mb The joys of programming a build system in sh! Signed-off-by: Leah Rowe --- include/vendor.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/include/vendor.sh b/include/vendor.sh index 8178fbf9..f307fcbd 100755 --- a/include/vendor.sh +++ b/include/vendor.sh @@ -62,6 +62,7 @@ detect_firmware() for c in CONFIG_HAVE_MRC CONFIG_HAVE_ME_BIN CONFIG_KBC1126_FIRMWARE \ CONFIG_VGA_BIOS_FILE CONFIG_INCLUDE_SMSC_SCH5545_EC_FW; do + eval "[ \"\${$c}\" = \"/dev/null\" ] && continue" eval "[ -z \"\${$c}\" ] || return 1" done printf "Vendor files not needed for: %s\n" "$board" 1>&2 -- cgit v1.2.1