summaryrefslogtreecommitdiff
path: root/util/nvmutil/nvmutil.c
AgeCommit message (Collapse)Author
25 hoursalso O_NOFOLLOWLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
25 hoursutil/nvmutil: dir fsync with O_DIRECTORYLeah Rowe
guards against replacement attacks, on systems that support this flag Signed-off-by: Leah Rowe <leah@libreboot.org>
25 hoursutil/nvmutil: fix mkstemp randomnessLeah Rowe
i made the string longer, but forgot to adjust it. the new random function is also better Signed-off-by: Leah Rowe <leah@libreboot.org>
25 hourscastLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
25 hoursutil/nvmutil: more reliable fallback cryptoLeah Rowe
we assume the fallback will be rare, so now we make the mix static and keep xoring it, on the theory that the number of failures on urandom will be random, and tthat the fallback may only apply once or twice in thousands of calls. the time jitter is adjusted; rather than judge the difference between two points close to each other in time, we judge tthe randomness in difference of time elapsed. this mitigates fast CPUs being very fast and introducing rounding errors, and also improves performonce on much slower CPUs Signed-off-by: Leah Rowe <leah@libreboot.org>
26 hoursutil/nvmutil: use real rename() syscallLeah Rowe
i was being cute earlier, but the rewrite defeats the purpose of atomic file handling in nvmutil, by not actually renaming! it was more like, doing an actual copy, which meant that corruption is likely during power loss i've commented the code because i may use it in a library in the future. Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursnvmutil: harden against hardlink attacksLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursredundancyLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursutil/nvmutil: loop EINTR on fsyncLeah Rowe
this improves reliability, making it more likely that data actually gets synced, since fsync can return -1 with EINTR, indicating that a re-try should be attempted. Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hourspointer safetyLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursdon't use PATH_MAXLeah Rowe
unreliable Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursmacro safetyLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursutil/nvmutil: portable S_IFMTLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursutil/nvmutil: remove integer typedefsLeah Rowe
better to just use standard names Signed-off-by: Leah Rowe <leah@libreboot.org>
28 hoursutil/nvmutil: remove global staticsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
29 hoursutil/nvmutil: fix unveil usageLeah Rowe
arandom probably isn't available on super old obsd right?????? rather, unveil isn't. on systems that have arandom yet we should not unveil something that may not exist on modern systems just don't unveil arandom, and don't check arandom if unveil is enabled Signed-off-by: Leah Rowe <leah@libreboot.org>
29 hoursutil/nvmutil: proper /dev/fd search in fchmodLeah Rowe
some systems may not even have it works with /dev/fd (bsd/mac etc) works with linux (/proc/self/fd) and falls back on super old systems that have neither Signed-off-by: Leah Rowe <leah@libreboot.org>
29 hoursutil/nvmutil: portable fchmodLeah Rowe
and with that, now the code compiles on gcc with -std=c90 -pedantic with -Werror and -Wall -Wextra Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursRevert "util/nvmutil: don't use fsync()"Leah Rowe
This reverts commit bdb43afac6edef21a15f99b8c3beac01be8b86f7.
30 hoursutil/nvmutil: longer string in mkstempLeah Rowe
have A-Z too, for more randomness Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: don't use mktempLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: don't declare libc prototypesLeah Rowe
i no longer use -Werror these can actually conflict on some weird systems, so better just remove them Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: portable memcpy/memcmpLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: more portable close()Leah Rowe
close may set errno to EINTR, which could cause weird edge case behaviour in our prw() functtion Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: more secure tmpdir()Leah Rowe
use stat instead of access (race conditions) Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: fix O_NONBLOCK fallbackLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: more secure mkstempLeah Rowe
try a few more times until success explicitly return EEXIST when needed we try multiple times and check more thoroughly if a file exists, thus reducing the risk of race conditions Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: more reliable TMPDIR handlingLeah Rowe
more portable Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: don't use fsync()Leah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: more portable functtionsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: add portable malloc externLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
30 hoursutil/nvmutil: don't use size_t/ssize_tLeah Rowe
not portable. some old systems don't have it, or handle it very poorly unsigned long is a reasonable way to refer to indexes inside pointters Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: don't use SSIZE_MAX (not portable)Leah Rowe
some old systems don't have ssize_t or size_t Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: typeset size_t explicitlyLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: run-time CHAR_BIT testLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: lower default PATH_LENLeah Rowe
older unix needed lower Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: portable struct timevalLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: portable S_ISREGLeah Rowe
very old libc doesn't have it Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursmktemp prototypeLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: portable gettimeofdayLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: use portable mkstempLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: better urandom portabilityLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: use local tmpfile on openbsdLeah Rowe
if the global file is created on a different file system than the gbe file, unveil would trigger an abort trap, since we rely on created a second temporary file, whose path we can't know ahead of time. i could get rid of unveil, or unveil a directory, but neither is acceptable. just use localtmp on openbsd. a temporary file is created next to the gbe file, in the same directory. Signed-off-by: Leah Rowe <leah@libreboot.org>
31 hoursutil/nvmutil: /dev/random fallbackLeah Rowe
now the custom fallback code is very unlikely to ever actually be used, on any system, except really old systems. Signed-off-by: Leah Rowe <leah@libreboot.org>
2 daysutil/nvmuttil: don't use arc4randomLeah Rowe
i have urandom again. it's enough the fallback rand implementation is used if needed now i don't have to worry about any weird version of unix from 1992 and deal with weird hacks. in fact, with this change, my code will probably compile on irix now Signed-off-by: Leah Rowe <leah@libreboot.org>
2 daysutil/nvmutil: re-enable urandom readsLeah Rowe
i had to loosen the pledges for the new i/o framework, which needs more permissions as a result, i can now open urandom in this function statically, rather than in nvmutil's control logic and because of that, it's less buggy now arc4random is disabled on linux by default, because it's not universally available on all libc, and only since about 2022 in some glibc versions better for portability to let linux users justt use urandom the new logic is different. now it falls back to rand per-byte, but in practise it almost never will. Signed-off-by: Leah Rowe <leah@libreboot.org>
2 daysutil/nvmutil: remove arc4random on linuxLeah Rowe
linux only had it since 2022. lots of people will complain if i leave this enabled. not all libc have it either Signed-off-by: Leah Rowe <leah@libreboot.org>
2 daysutil/nvmutil: fix catLeah Rowe
i simplified it in the last commits, but i sttill need this loop to properly handle parts otherwise yeah, all it's doing is copying a file verbatim. duh. Signed-off-by: Leah Rowe <leah@libreboot.org>
2 daysutil/nvmutil: double-verify r/w using tmp filesLeah Rowe
we now read twice, verify the two, to make sure one read isn't faulty we operate on a tmp file, then rename back. this reduces the risk of power cuts corrupting data we properly verify the contents that we wrote back inspired largely by flashprog. i wanted to have an insanely over-engineered and extremely safe tool that edits intel gbe nvm files and now i have one. the only one in existence. i'm basically writing my own libc code at this point, to be honest. i'll probably start puttting these functions in libraries e.g. that tmpfile generator Signed-off-by: Leah Rowe <leah@libreboot.org>
3 daysnvmutil: use O_CLOEXEC on gbe filesLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
generated by cgit v1.2.1 (git 2.18.0) at 2026-03-17 22:13:14 +0000