summaryrefslogtreecommitdiff
path: root/resources
AgeCommit message (Collapse)Author
2023-05-15download/coreboot: avoid variable conflictLeah Rowe
the "board" variable in prepare_new_coreboot_tree() is also declared in fetch_coreboot_trees for the one in prepare_new_coreboot_tree, it's passed as an argument to the function, so give it a new name i learned that some shells have a global scope, when using variables of the same name between functions
2023-05-15download/coreboot: fix downloads without argumentLeah Rowe
this should download all trees: ./download coreboot without this patch, it doesn't with this patch, it works i overlooked this during earlier refactoring. auditing revealed it.
2023-05-15download/coreboot: much cleaner coding styleLeah Rowe
top-down order, and *still* rfc 3676 compliant i finished simplifying the logic, and i split everything into smaller functions there is still more more polishing to do final touches will be done in new revisions
2023-05-15download/coreboot: clone upstream via ./gitcloneLeah Rowe
coreboot trees/patching is still handled specifically by "./download coreboot" command now available in lbmk: ./gitclone coreboot this *only* creates the directory at: coreboot/coreboot this directory is never used in builds. it is only used by download/coreboot to create patched trees for each mainboard
2023-05-15download/coreboot: simplify checkLeah Rowe
2023-05-15download/coreboot: fix misnamed functionLeah Rowe
2023-05-15download/coreboot: simplify small if statementsLeah Rowe
2023-05-15download/coreboot: fetch config in new functionLeah Rowe
2023-05-15download/coreboot: use global variablesLeah Rowe
i'm going to move the config recursion check into a separate function, and global variables make it easier to handle
2023-05-15download/coreboot: rename function for clarityLeah Rowe
2023-05-15download/coreboot: reduce indentation in loopLeah Rowe
2023-05-15download/coreboot allow downloading specific treesLeah Rowe
this fixes a regression caused in previous (recent) revisions. this script is a beast, and requires a lot of taming, which is the purpose of my audit
2023-05-15download/coreboot: split config check to functionLeah Rowe
2023-05-15download/coreboot: fix misnamed variableLeah Rowe
2023-05-15download/coreboot: consistent function declarationLeah Rowe
2023-05-15download/coreboot: rename function for clarityLeah Rowe
2023-05-15download/coreboot: prune errant commentsLeah Rowe
2023-05-15download/coreboot: split main()Leah Rowe
2023-05-15download/coreboot functions: rename board variableLeah Rowe
2023-05-15download/coreboot: top-down re-orderingLeah Rowe
main first usage last
2023-05-15download/coreboot: simplified for loopsLeah Rowe
2023-05-15download/coreboot: move initial logic to main()Leah Rowe
2023-05-15download/coreboot: RFC 2646 complianceLeah Rowe
yes, i know 3676 supersedes 2646 i still say 2646 saying 2646 is still technically valid, for my purposes
2023-05-14download/coreboot: consistent tab indentationLeah Rowe
2023-05-14build/seabios: cleaner coding styleLeah Rowe
top-down logic, main() on top moved some hardcoded strings to variables
2023-05-14build/seabios: simplify. stricter error handlingLeah Rowe
2023-05-14blobutil/download: cleaner coding styleLeah Rowe
consistent indentation, and 80-line character limit (RFC 2646) top-down order, a main() is introduced, split into more functions non-zero-status exit (with message) now, when a non- defined target is provided, e.g. nonexistentboard_4mb puffy!
2023-05-14download/mrc: stricter error handlingLeah Rowe
the cbfstool command within subshell now also exits with non-zero status, if it fails (most likely because extraction failed, for some reason, of the coreboot rom image for running through it)
2023-05-14download/mrc: handle exit status within subshellLeah Rowe
the previous code merely exited from the subshell, but the intended behaviour is for the entire script to halt execution, and exit with non-zero status. this patch fixes that bug.
2023-05-14download/mrc: use cleaner coding styleLeah Rowe
top-down order for all logic, and shorter code lines, conforming to rfc 2646 (no more than 80 characters) the 80-character rule is violated for variables containing long strings, such as wayback machine urls (can't be helped) a few bugs were discovered, which will be fixed in follow-up revisions, such as: * exit status not handled inside subshell * in general, exit status should be handled more explicitly, rather than relying on -e
2023-05-14download/grub: delete grub if gnulib cloning failsLeah Rowe
for our purposes, grub and gnulib are one in the same if one fails, both have failed exit with non-zero status if gnulib fails the script sets -e so it will fail if grub fails to download, which is tried before gnulib, and if that happens, the grub directory is not created
2023-05-14build/dependencies/*: RFC 2646 complianceLeah Rowe
2023-05-14update/coreboot: top-down coding styleLeah Rowe
also moved hardcoded strings into variables
2023-05-14blobutil/extract: minor code style cleanupLeah Rowe
2023-05-14blobutil/extract: split up extract_blobs()Leah Rowe
2023-05-14blobutil/extract: cleaner coding styleLeah Rowe
removed hardcoded strings, put them in variables use easier to read lowercase for function names
2023-05-14blobutil/extract: simplified main()Leah Rowe
2023-05-14blobutil/extract: top-down logicLeah Rowe
2023-05-14blobutil/extract: RFC 2646 compliance (80 chars)Leah Rowe
2023-05-14blobutil/inject: print script path on errorLeah Rowe
2023-05-14blobutil/inject: fail if gbe.bin doesn't existLeah Rowe
2023-05-14blobutil/inject: check that me.bin existsLeah Rowe
2023-05-14blobutil/inject: check me pathLeah Rowe
2023-05-14blobutil/inject: remove errant debug messageLeah Rowe
i left this here by accident when testing something during work on a prior revision
2023-05-14blobutil/inject: use x86 top-aligned mrc offsetLeah Rowe
the old code was specifing an absolute offset for insertion of mrc.bin - cbfstool interprets anything above 0x80000000 as top-aligned memory address in x86, and anything below as an obsolute offset in the flash, like with the old number where a top-aligned address is provided to cbfstool, the absolute position is calculated for the flash, and cbfstool inserts it in the correct rom location the benefit of this change is that the absolute offset is now calculated automatically, which means that the code will be correct even if the flash size changes. for example, if 16MB flash is used whereas 12MB is currently the default an support haswell hardware coreboot does not provide anything readably like Kconfig, for extracting this value. it's baked into the source code of coreboot, so you have to find it. the correct location is hardcoded for each platform, and always the same on each platform, regardless of mainboard
2023-05-14remove errant code lines from last commitLeah Rowe
2023-05-14blobutil/inject: massively improved coding styleLeah Rowe
top-down function order, with specific functions for each type of blob. startup logic moved into main(), also split into smaller functions "write one program that does one thing well" blobutil is like that, and has this added philosophy: "write one function that does one thing well" during the course of this re-factoring, several bugs and issues were found, that are pre-existing. these will be corrected in follow-up revisions
2023-05-13Merge pull request 'Remove warning for coreboot images build without a ↵Leah Rowe
payload' (#65) from nic3-14159/lbmk:remove-no-payload-warning into master Reviewed-on: https://codeberg.org/libreboot/lbmk/pulls/65
2023-05-13modify/u-boot: cleaner coding styleLeah Rowe
similar to the previous revision
2023-05-13modify/coreboot: cleaner coding styleLeah Rowe
similar to the previous revision