summaryrefslogtreecommitdiff
path: root/resources/scripts/download/coreboot
AgeCommit message (Collapse)Author
2023-05-24download/coreboot: fix error handling in subshellLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-24download/coreboot: don't needlessly re-downloadLeah Rowe
2023-05-21download/coreboot: remove unnecessary bloatLeah Rowe
it is not necessary to have help output similarly, listing all boards in this script is pointless. why not just run ls -1 on the directory?
2023-05-18download/coreboot: minor cleanupLeah Rowe
2023-05-15download/coreboot: minor code cleanupLeah Rowe
i'm pretty much finished now there might be a few more changes later, like stricter error handling, more verbose error messages, etc right now, it relies on -e to kill lbmk on error, and uses the exit command another planned change it to support other upstreams besides coreboot.org, such as the dasharo codebase the latter is *why* i refactored this download script, for asus kgped-d16
2023-05-15download/coreboot: remove errant codeLeah Rowe
the build_error file is obsolete
2023-05-15download/coreboot: tidy up variable namesLeah Rowe
2023-05-15download/coreboot: run extra.sh from cbtreeLeah Rowe
to my knowledge, this feature has never been used, but lbmk permits resources/coreboot/boardname/extra.sh to execute, as provided by the maintainer, with working directory set to: coreboot/boardname this could be used to extend lbmk in a number of ways for example, it could be used to patch 3rdparty/ it could also be used to break coreboot in creative and novel ways. hint hint.
2023-05-15download/coreboot: avoid variable conflictLeah Rowe
the "board" variable in prepare_new_coreboot_tree() is also declared in fetch_coreboot_trees for the one in prepare_new_coreboot_tree, it's passed as an argument to the function, so give it a new name i learned that some shells have a global scope, when using variables of the same name between functions
2023-05-15download/coreboot: fix downloads without argumentLeah Rowe
this should download all trees: ./download coreboot without this patch, it doesn't with this patch, it works i overlooked this during earlier refactoring. auditing revealed it.
2023-05-15download/coreboot: much cleaner coding styleLeah Rowe
top-down order, and *still* rfc 3676 compliant i finished simplifying the logic, and i split everything into smaller functions there is still more more polishing to do final touches will be done in new revisions
2023-05-15download/coreboot: clone upstream via ./gitcloneLeah Rowe
coreboot trees/patching is still handled specifically by "./download coreboot" command now available in lbmk: ./gitclone coreboot this *only* creates the directory at: coreboot/coreboot this directory is never used in builds. it is only used by download/coreboot to create patched trees for each mainboard
2023-05-15download/coreboot: simplify checkLeah Rowe
2023-05-15download/coreboot: fix misnamed functionLeah Rowe
2023-05-15download/coreboot: simplify small if statementsLeah Rowe
2023-05-15download/coreboot: fetch config in new functionLeah Rowe
2023-05-15download/coreboot: use global variablesLeah Rowe
i'm going to move the config recursion check into a separate function, and global variables make it easier to handle
2023-05-15download/coreboot: rename function for clarityLeah Rowe
2023-05-15download/coreboot: reduce indentation in loopLeah Rowe
2023-05-15download/coreboot allow downloading specific treesLeah Rowe
this fixes a regression caused in previous (recent) revisions. this script is a beast, and requires a lot of taming, which is the purpose of my audit
2023-05-15download/coreboot: split config check to functionLeah Rowe
2023-05-15download/coreboot: fix misnamed variableLeah Rowe
2023-05-15download/coreboot: consistent function declarationLeah Rowe
2023-05-15download/coreboot: rename function for clarityLeah Rowe
2023-05-15download/coreboot: prune errant commentsLeah Rowe
2023-05-15download/coreboot: split main()Leah Rowe
2023-05-15download/coreboot functions: rename board variableLeah Rowe
2023-05-15download/coreboot: top-down re-orderingLeah Rowe
main first usage last
2023-05-15download/coreboot: simplified for loopsLeah Rowe
2023-05-15download/coreboot: move initial logic to main()Leah Rowe
2023-05-15download/coreboot: RFC 2646 complianceLeah Rowe
yes, i know 3676 supersedes 2646 i still say 2646 saying 2646 is still technically valid, for my purposes
2023-05-14download/coreboot: consistent tab indentationLeah Rowe
2022-12-28Do not rely on bashisms and behaviour undefined by the POSIX specification. ↵Ferass 'Vitali64' EL HAFIDI
Part 2 Signed-off-by: Ferass 'Vitali64' EL HAFIDI <vitali64pmemail@protonmail.com>
2022-12-05remove errant detail from commentLeah Rowe
2022-11-14pragmatic system distribution guideline compliancepsdgLeah Rowe
osboot is now part of libreboot, and will soon shut down. libreboot now conforms to osboot policy.
2022-08-27download: Use shallow clones for big projectsAlper Nebi Yasak
Downloading coreboot and U-Boot takes quite the disk space and bandwith. We don't need to download entire repos, only the revisions that we are interested in. Use the --depth=1 option to only download the files we need. Since the initial clones may not have our target revision, always try to fetch it. Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
2022-08-27download: Allow keeping .git dirs with NODELETE=gitAlper Nebi Yasak
Keeping the git repositories is useful while development, e.g. to avoid git cloning repositories over and over again while debugging download scripts. Setting the NODELETE environment variable keeps the blobs and the git repositories. Allow a slightly finer-tuned version of this where we can keep only the git-related files by setting the variable to "git". Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
2022-03-06scripts: download: coreboot: fix ./download allDenis 'GNUtoo' Carikli
When running ./download all, we have the following error: resources/scripts/download/coreboot: Line 52: $1 is not set. The ./download all command was broken by the following commit: 2bb805e2e07a7d3e1268a09d720ecd13e26af418 (download: Add --help in the individual download scripts). Reported-by: madbehaviorus[m] on #libreboot on liberachat Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
2022-02-16download: Add --help in the individual download scriptsDenis 'GNUtoo' Carikli
This doesn't change the existing usage of the scripts: - For the Coreboot script, before this change, all arguments that were passed were considered as board to download the Coreboot source code for. Here we added the '--help' and '--list-boards' arguments, so it should not be an issue as it is extremely unlikely that a board would be called '--help' or '--list-boards'. - All the other scripts don't use any arguments so passing --help should not conflict with the existing usage. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
2022-02-10scripts: download: coreboot: Fix check for build errorDenis 'GNUtoo' Carikli
build_error is supposed to be a file since it's created with touch. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
2021-06-03replace #!/bin/bash with #!/usr/bin/env bashRon Nazarov
2021-05-18libreboot!Leah Rowe
this is forked from the "libre" branch in osboot, which is itself a libre, deblobbed fork of osboot, a blobbed up fork of libreboot libreboot needed to be purged clean. this is the new libreboot development repository. the old one has been abandoned