summaryrefslogtreecommitdiff
path: root/resources/scripts/build
AgeCommit message (Collapse)Author
2023-05-27build/payload/seabios: reduced indentationLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-27Remove most of Ferass's lbmk contributionsLeah Rowe
The primary purpose of my intense auditing has been to improve lbmk's coding style and fix bugs but there is a secondary purpose: know precisely who owns what, because I want to re-license as much as possible of lbmk under *MIT*, instead of the current GNU licensing. MIT is vastly superior, because it grants *actual* freedom to the user, permits *sublicensing* and it is vastly more compatible with other GPL combinations; for example, MIT license is compatible with GPL2-only whereas lbmk's current mix of GPLv3-or-later and GPLv3-only is legally incompatible with GPLv2-only. Re-licensing under MIT will most likely result in more contributions to Libreboot's build system in the future, especially as it will attract a lot more commercial interest. Contrary to the popular arguments, copyleft is a liability to the free software movement and results in less code being written; in practise, permissively licensed code gets more public contributions, including from commercial entities, even if companies can theoretically make something proprietary out of it (in practise, anyone inclined can just use the upstream and proprietary forks almost always die). Copyleft propaganda is fundamentally flawed. See: <https://unixsheikh.com/articles/the-problems-with-the-gpl.html> Anyway, I've been doing a combination of: * Seeking permission from other copyright holders, for re-licensing * Deleting, or moving, other contributions; for example, splitting certain contributions into separate files so that originally modified files become unencumbered. This latter solution is a result of *code cleanup* arising from the audit. For Ferass's contributions, I opted to seek *permission*, and permission was denied. In full compliance with this legal imperative, I'm acting accordingly; this commit removes all of Ferass's changes that converted lbmk to posix shell scripts, thus removing his copyright on the affected files, bypassing his authority entirely. Therefore, lbmk is largely now bash-dependent. In practise, nobody is going to use anything other than a GNU system to build Libreboot, because many projects that Libreboot makes use of rely heavily on GNU; for example, coreboot's build system makes heavy use of GNU-specific extensions in *GNU Make*, and likely contains many bashisms. Of course, Libreboot also compiles GNU GRUB. I would much rather have MIT-licensed Bash scripts than GPL-licensed posix SCL scripts. This reverts the changes from Ferass El Hafidi, for the following commits, with some exceptions: * 7f5dfebf7d37c56d9c7993aaa17c59070cb5aec9 * f787044642236917c9c4dbcaa48a6b0648097db0 Exception: download/mrc not reverted, because that was already a fork of an existing script under coreboot's build system, and their script was GPLv2. i cannot/will not re-license this file (ergo, 7f5dfebf7d37c56d9c7993aaa17c59070cb5aec9 change remains intact, on this file) resources/scripts/build/boot/roms_helper, these changes have been kept: * 7e6691e9 - Add ARMv7 and AArch64 support * dec2d720 - add myself in the build/roms_helper script (added 2021 copyright for the change below) * b7405656 - Workaround for grub's slow boot ^ these changes will be re-factored, splitting them out of the file into a new file. This will be done in a future lbmk revision. (in some cases, it makes sense to keep a change but split it, allowing the main file to be re-licensed without the change in it) This is part of a much larger series of licensing audits. It's likely that lbmk will be posix-compliant (in its shell scripts) again some day, because I'm planning to rewrite most of these scripts (the ones modified in this patch), and many of them (e.g. individual download scripts) are subject to future deletion in a planned overhaul of the download logic for third party projects. In addition: these changes are being kept (no attempt to re-license them will be made): * cff081c6 - Fix grub's slow boot (1 year, 5 months ago) <Vitali64> * 4c851889 - Add macbook*1 16mb configs (1 year, 6 months ago) <Vitali64> Ferass's work that remains will be split into dedicated files containing them, where feasible. In the case of grub.cfg (for GNU GRUB), I don't care because it's a script for an engine (GRUB shell) that's under GPL anyway, so who really cares about MIT license. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/clean/u-boot: remove unnecesssary checkLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/clean/u-boot: improved coding styleLeah Rowe
tabs for indentation simplify some checks
2023-05-20build/clean/ich9utils: don't use subshellLeah Rowe
this also fixes error handling Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/u-boot: top-down, split-function code styleLeah Rowe
main() on top top-down order of logic logic split into separate functions Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/payload/u-boot: 79 chars or less per lineLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/payload/u-boot: fix wrong attributionsLeah Rowe
only alper and ferass have ownership of this file, but ferass only submitted to it in 2022, not 2021 fix this i've removed myself from the file, for now i never touched this file before, so it's not right that my name be here put alper's name at the top, because alper was the person who created this file first Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/payload/grub: rename functions for clarityLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/payload/grub: remove unnecessary checkLeah Rowe
sed does the same job as cp, in this situation Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/payload/grub: split logic into functionsLeah Rowe
main() on top top-down logic Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/payload/grub: 79 chars or less per lineLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/roms: minor cleanupLeah Rowe
split actual purging of blobs to a function rename functions for clarity
2023-05-20build/release/roms: handle argument properlyLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/roms: remove superfluous commentsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/roms: handle errors inside subshellLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/roms: split logic into functionsLeah Rowe
main() on top top-down logic 79 chars or less, per line Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/roms: use tabs for indentationLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/src: 79 chars or less per code lineLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/src: handle errors in subshellsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/release/src: split logic into functionsLeah Rowe
main() on top top-down logic Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/ich9utils: simplify, fix error handlingLeah Rowe
errors weren't being handled inside a subshell Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/memtest86plus: use tabs for indentationLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/clean/crossgcc: better code styleLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/descriptors: simplify and fix error handlingLeah Rowe
main() on top some parts of the script weren't erroring properly Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/grub: fix inconsistent indentationLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/grub: implement error handlingLeah Rowe
it uses a subshell, so errors weren't observed Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/grub: introduce main(), split it upLeah Rowe
easier to read Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/cbutils: remove unnecessary directory checkLeah Rowe
it will already fail if the coreboot download did. if the coreboot download succeeds, the directory exists. Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/cbutils: rename function for clarityLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/cbutil: avoid frivilous use of subshellsLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/cbutils: top-down coding style, main on topLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/cbutils: 79 chars or less per lineLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20build/cbutils: use tabs for indendationLeah Rowe
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-14build/seabios: cleaner coding styleLeah Rowe
top-down logic, main() on top moved some hardcoded strings to variables
2023-05-14build/seabios: simplify. stricter error handlingLeah Rowe
2023-05-14build/dependencies/*: RFC 2646 complianceLeah Rowe
2023-05-13build/build/roms: simplify mkCoreboot() argumentsLeah Rowe
2023-05-13build/boot/roms: don't use subshells frivilouslyLeah Rowe
use make -BC instead of cd
2023-05-13build/boot/roms: remove errant debug lineLeah Rowe
i added this in the last revision it was put there to debug something that i fixed before pushing
2023-05-13build/boot/roms: simplify build_rom_images()Leah Rowe
2023-05-13build/boot/roms: use fast dd command for ich9m ifdLeah Rowe
bs 12k and count 1, rather than bs 1 and count 12k
2023-05-13build/boot/roms: don't run ich9gen twiceLeah Rowe
2023-05-13build/boot/roms: simplify moverom()Leah Rowe
2023-05-13build/boot/roms: remove unused legacy codeLeah Rowe
this cuttype is no longer used lbmk creates truncated me setups now, on ifd platforms
2023-05-13build/boot/roms: reduced code indentationLeah Rowe
2023-05-12build/boot/roms: split main() to topdown functionsLeah Rowe
the logic can now more or less be read chronologically
2023-05-12build/roms_helper: move logic into main()Leah Rowe
logic will be split from main into smaller functions, in follow-up commits
2023-05-10build/boot/roms_helper: further cleanupLeah Rowe
consolidated some for loops removed errant code
2023-05-10build/boot/roms: top-down function orderLeah Rowe