summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-08util/nvmutil file reads: skip reading if errno!=0Leah Rowe
*This condition will probably never be met, but it is theoretically possible that the code could still fail at this point. Catch all errors, and exit, ruthlessly.
2022-12-08util/nvmutil: return error when fstat() is -1Leah Rowe
Another oversight in my error handling.
2022-12-07util/nvmutil: rhex(): fail if errno not zeroLeah Rowe
The code was only checking whether all of the bytes were read, but there are other errors that can be caught via errno. Enforce strict errno handling, when generating random numbers for command `setmac`.
2022-12-05util/nvmutil: minor code formatting cleanupLeah Rowe
2022-12-05build/release/roms: delete ME/MRC firmware in ROMsLeah Rowe
2022-12-05build/boot/roms: remove errant codeLeah Rowe
2022-12-05remove errant detail from commentLeah Rowe
2022-12-05delete build/release/u-boot-libreLeah Rowe
this is a hangover from pre-osboot-merge libreboot. the idea was to distribute fsdg uboot archives lbmk has uboot support, and releases will simply include uboot in the main src archive like with everything else
2022-12-05remove logic for avoiding nonredistributable blobsLeah Rowe
the --nuke option in ifdtool will be used instead, to nuke the ME regions in specific rom sets (and cbfstool will be used to delete mrc.bin files from rom sets) the new method being implemented is heavier on disk io, but simplifies lbmk, and disk io could still be optimised in the following ways: * when copying roms from boards with ME in them, use ifdtool --nuke to get filename.rom.new, and *move* (not copy) filename.rom.new to the new destination (for use with tar) * possibly modify ifdtool to make efficient use of mmap for disk i/o; it currently loads entire roms into an allocated buffer in memory
2022-12-04coreboot/default: add --nuke flag to ifdtoolLeah Rowe
e.g. ./ifdtool --nuke me coreboot.rom this will be used by rom release build scripts, to scrub stuff like intel me from the rom
2022-12-03util/nvmutil: remove errant line breakLeah Rowe
2022-12-03util/nvmutil: missing paretheses on if statementLeah Rowe
2022-12-03util/nvmutil: don't initialise rbuf unless neededLeah Rowe
previously, it was always initialised, but now it's only initialised if '?' is used on a mac address character in command `setmac` this is done by simply moving mac address character randomisation to a separate function
2022-12-03util/nvmutil: rename variable in hextonumLeah Rowe
2022-12-03util/nvmutil: don't reallocate memory in hextonumLeah Rowe
2022-12-03util/nvmutil: dont report bad size if /dev/urandomLeah Rowe
2022-12-03util/nvmutil: rename variables in hextonumLeah Rowe
2022-12-03util/nvmutil: use BUFSIZ for rmac size in hextonumLeah Rowe
I will be using this function elsewhere, and in general I want this to be usable for lots of programs.
2022-12-03util/nvtutil: fix out of bounds errorLeah Rowe
the error would have never been triggered, because it never went over 11, but if this code were to be copied elsewhere, it would be problematic
2022-12-02update the READMELeah Rowe
2022-12-01util/nvmutil: reset errno on cmd_swapLeah Rowe
If one of the checksums was valid, but the other was not, errno would be set to E_CANCELED, but then the buffer would be modified anyway; this is acceptable behaviour, and errno would later be reset writing the GBE file, which is done only on the condition that the buffer was modified, but it's also a good idea to reset it here just in case. This is not a bugfix, and no behavioural changes will be observed by the user, but this may *prevent* a bug in the future, so let's pre-fix that bug now.
2022-11-29scripts: avoid relying on spaces from sha1sum outputAlexei Sorokin
2022-11-29Merge branch 'hide-mei' of XRevan86/lbmk into masterLeah Rowe
2022-11-29coreboot: hide MEI on neutered-ME targetsAlexei Sorokin
2022-11-29Merge branch 'master' of Arsen/lbmk into masterLeah Rowe
2022-11-29Merge branch 'x230edp' of XRevan86/lbmk into masterLeah Rowe
2022-11-28t430_12mb: Add, based on x230_12mbArsen Arsenović
These boards are near-identical, this appears to suffice.
2022-11-28coreboot: add x230edp_12mb, remove x230fhd_12mbAlexei Sorokin
New x230edp_12mb target uses the https://review.coreboot.org/c/coreboot/+/28950 patchset to add an X230_EDP target to the default coreboot branch. Consequently the "fhd" coreboot branch is no longer needed and has been safely removed.
2022-11-27util/nvmutil: mild refactoringLeah Rowe
2022-11-27util/nvmutil: improved errno handling in mainLeah Rowe
2022-11-27util/nvmutil: put hextonum in its own functionLeah Rowe
2022-11-27util/nvmutil: move ENOTDIR check to functionLeah Rowe
2022-11-27util/nvmutil: further improved errno handlingLeah Rowe
2022-11-27util/nvmutil: remove errant codeLeah Rowe
2022-11-27util/nvmutil: improved error handlingLeah Rowe
2022-11-26util/nvmutil: fix off by one bugLeah Rowe
2022-11-26nvmutil copy/swap: actually set nvmPartModifiedLeah Rowe
2022-11-26util/nvmutil: move cmd copy to own functionLeah Rowe
2022-11-26util/nvmutil: move cmd swap to own functionLeah Rowe
2022-11-26util/nvmutil: move cmd brick to own functionLeah Rowe
2022-11-26util/nvmutil: cmd setchecksum in own functionLeah Rowe
2022-11-26util/nvmutil: split "dump" into smaller functionsLeah Rowe
2022-11-26Merge branch 'dev' of shmalebx9/lbmk into masterLeah Rowe
2022-11-26fix injection scriptshmalebx9
2022-11-26added more checks and optimised extraction scriptshmalebx9
2022-11-26util/nvmutil: re-factor to reduce code indentationLeah Rowe
2022-11-26util/nvmutil: write gbe files in a functionLeah Rowe
in any C program, main() should not contain detailed logic. ideally, the main() function should only be a skeleton, showing the overall logic flow of the program. split writing gbe files into a separate function, to satisfy this criteria.
2022-11-26util/nvmutil: human-friendly exit messages, part 2Leah Rowe
2022-11-24Merge branch 'qemu' of shmalebx9/lbmk into masterLeah Rowe
2022-11-22build/roms: remove seabios_grubfirst logicLeah Rowe
the intended use-case scenario was one in which vga rom initialisation would be used, on desktop configurations, but without coreboot itself handling vga rom initialisation, instead leaving that task to seabios it was assumed that grub, when running on the bare metal with build option "--with-platform=coreboot" would be able to display like this, but it is not so when tested in such setups (add-on gpu with grub payload), it is necessary to extract the video bios and insert it into the coreboot rom, having coreboot handle such execution. this is beyond the scope of lbmk, in context of automated building, because we cannot reliably predict things such as PCI IDs do away with this build option entirely, for it does not serve the intended purpose. it will be necessary to run PC GRUB instead (build option --with-platform=i386-pc). PC GRUB can still read from CBFS, and you could provide it as a floppy image file inside CBFS for SeaBIOS to execute. in this setup, GRUB would function as originally intended by the seabios_withgrub option; such a configuration is referred to as "SeaGRUB" by the libreboot project, and experimentation was done with it in the past, to no avail it's better to keep things simple, in the libreboot project. simpler for users, that is