summaryrefslogtreecommitdiff
path: root/script/build/release
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-09-09 23:15:17 +0100
committerLeah Rowe <leah@libreboot.org>2023-09-09 23:15:17 +0100
commit84bf47b5b947a8ed5afa1fb5335266d04ee3b004 (patch)
tree48e7512bececf2fc03f7d2eba4b45cd36bf219f4 /script/build/release
parentb78009e28aab38bc149be5c57aa23505b8dd2a08 (diff)
scripts: better handling of printf: stdout/stderr
in some cases, messages that should be considered errors or warnings, were being written to the standard output, rather than written as error messages. also: one or two printf statements should specifically avoid printing errors (to any file); in these cases, stdout has been redirected to /dev/null Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/release')
-rwxr-xr-xscript/build/release/roms6
1 files changed, 3 insertions, 3 deletions
diff --git a/script/build/release/roms b/script/build/release/roms
index c551c1aa..da67f8ed 100755
--- a/script/build/release/roms
+++ b/script/build/release/roms
@@ -191,9 +191,9 @@ strip_ucode()
"${cbfstool}" "${_newrom_b}" remove -n \
cpu_microcode_blob.bin 2>/dev/null || microcode_present="n"
if [ "${microcode_present}" = "n" ]; then
- printf "REMARK: '%s' already lacks microcode\n" \
- "${romfile}"
- printf "Renaming default ROM file instead.\n"
+ printf "REMARK: '%s' already lacks microcode\n" "${romfile}" \
+ 1>&2
+ printf "Renaming default ROM file instead.\n" 1>&2
mv "${romfile}" "${_newrom_b}" || \
err "strip_rom_image: can't rename no-u ${romfile}"
fi