summaryrefslogtreecommitdiff
path: root/script/build/fw/coreboot
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-10-07 03:06:20 +0100
committerLeah Rowe <leah@libreboot.org>2023-10-07 03:06:20 +0100
commitb6d9e6c18ded5659ef5d0ea950133bdb0bb5c772 (patch)
tree388b8057693582b099d81ed56fb581918a879d49 /script/build/fw/coreboot
parent0962600c8402665992e7ebfac3cee7a2aad959fd (diff)
build/fw/coreboot: don't support no-all all arg
it's buggy. "./build fw coreboot" was made to work, but it caused lots of unknown issues when mixing other args the old way wasn't broken. now, once again, you must pass the "all" argument. e.g.: ./build fw coreboot all Also, the confirmation messages at the end are a bit clearer, when listing which ROM images were compiled. Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/fw/coreboot')
-rwxr-xr-xscript/build/fw/coreboot8
1 files changed, 4 insertions, 4 deletions
diff --git a/script/build/fw/coreboot b/script/build/fw/coreboot
index db6dd443..2f11e725 100755
--- a/script/build/fw/coreboot
+++ b/script/build/fw/coreboot
@@ -45,8 +45,7 @@ main()
shift 2
done
- [ "${all}" = "y" ] && boards=""
- [ ! -z ${boards} ] || boards=$(listitems config/coreboot) || \
+ [ "${all}" != "y" ] || boards=$(listitems config/coreboot) || \
err "Cannot generate list of boards for building"
for x in ${boards}; do
@@ -56,11 +55,12 @@ main()
check_target
prepare_target
[ -d "bin/${board}" ] || continue
- targets="bin/${board}, ${targets}"
+ targets="* bin/${board}\n${targets}"
done
[ -z ${targets} ] && err "No ROM images were compiled"
- printf "ROM images available in these directories:\n${targets%, }\n"
+ printf "\nROM images available in these directories:\n"
+ printf "${targets}^^ ROM images available in these directories.\n\n"
}
check_target()