summaryrefslogtreecommitdiff
path: root/script/build/boot/roms_helper
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-09-10 15:05:19 +0100
committerLeah Rowe <leah@libreboot.org>2023-09-10 15:05:19 +0100
commit308c21dd438e5dc27b232a0c31f0e68244ab364f (patch)
tree576fc92bec70ef55c27f77d78448e444db417492 /script/build/boot/roms_helper
parentc16b28efad439fed7a5462b2deaf0a63594d3212 (diff)
build/boot/roms stragglers: properly handle errors
there were a few missing err calls i actually went through all of lbmk and found no instances where err calls were missing except in build/boot/roms_helper Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'script/build/boot/roms_helper')
-rwxr-xr-xscript/build/boot/roms_helper7
1 files changed, 5 insertions, 2 deletions
diff --git a/script/build/boot/roms_helper b/script/build/boot/roms_helper
index 5b64ad0e..ff8772eb 100755
--- a/script/build/boot/roms_helper
+++ b/script/build/boot/roms_helper
@@ -317,7 +317,8 @@ build_seabios_roms()
else
x=${corebootrom}
y=${initmode}
- t=$(mkSeabiosRom "$x" "fallback/payload" "$y")
+ t=$(mkSeabiosRom "$x" "fallback/payload" "$y") || \
+ err "build_seabios_roms: cannot build tmprom"
if [ "${initmode}" = "normal" ]; then
newrompath="${romdir}/seabios_${board}_"
newrompath="${newrompath}${initmode}.rom"
@@ -347,7 +348,9 @@ build_grub_roms() {
y=${initmode}
if [ "${payload_grub_withseabios}" = "y" ] && \
[ "${firstpayloadname}" = "grub" ]; then
- mv "$(mkSeabiosRom "${x}" "seabios.elf" "${y}")" "${tmprompath}"
+ mv "$(mkSeabiosRom "${x}" "seabios.elf" "${y}")" \
+ "${tmprompath}" || \
+ err "build_grub_roms: cannot move tmp rom (seabios.elf)"
elif [ "${payload_seabios_withgrub}" = "y" ] && \
[ "${firstpayloadname}" != "grub" ]; then
mv "$(mkSeabiosRom "${x}" "fallback/payload" "$y")" \