summaryrefslogtreecommitdiff
path: root/resources/scripts/download/coreboot
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-05-15 04:14:50 +0100
committerLeah Rowe <leah@libreboot.org>2023-05-15 04:14:50 +0100
commitc4b0825c5e70697bac187a0a953cf9b8d122162c (patch)
tree52cdc19eaa89b02b1b2f4d492fc6edbb6e5a05b2 /resources/scripts/download/coreboot
parent0e1e9c1773734c38426529ba8cda2f5b9e5b8f9b (diff)
download/coreboot: avoid variable conflict
the "board" variable in prepare_new_coreboot_tree() is also declared in fetch_coreboot_trees for the one in prepare_new_coreboot_tree, it's passed as an argument to the function, so give it a new name i learned that some shells have a global scope, when using variables of the same name between functions
Diffstat (limited to 'resources/scripts/download/coreboot')
-rwxr-xr-xresources/scripts/download/coreboot6
1 files changed, 3 insertions, 3 deletions
diff --git a/resources/scripts/download/coreboot b/resources/scripts/download/coreboot
index f120270c..4f9855dc 100755
--- a/resources/scripts/download/coreboot
+++ b/resources/scripts/download/coreboot
@@ -163,13 +163,13 @@ gitclone_coreboot_from_upstream()
prepare_new_coreboot_tree()
{
- board=${1}
+ target=${1}
cbtree=${2}
cbrevision=${3}
printf "Preparing coreboot tree: %s\n" ${cbtree}
- [ "${cbtree}" != "${board}" ] && \
- printf "(for board: %s)\n" "${board}"
+ [ "${cbtree}" != "${target}" ] && \
+ printf "(for board: %s)\n" "${target}"
cp -R coreboot/coreboot "coreboot/${cbtree}" || exit 1
(