summaryrefslogtreecommitdiff
path: root/resources/scripts/build/grub/utils
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-08-24 20:19:41 +0100
committerLeah Rowe <leah@libreboot.org>2023-08-26 16:58:32 +0100
commit1c8401be25e4749a2eee5ddc77ce7c6ac880c910 (patch)
tree22789efec9b91ffddb21653a30b8591a8b63d3bf /resources/scripts/build/grub/utils
parent50c395df59564c19d3a24262810c8dd5ed115db5 (diff)
much, much stricter, more verbose error handling
lbmk is much more likely to crash now, in error conditions, which is a boon for further auditing. also: in "fetch", remove the downloaded program if fail() was called. this would also be done for gnulib, when downloading grub, but done in such a way that gnulib goes first. where calls to err write "ERROR" in the string, they no longer say "ERROR" because the "err" function itself now does that automatically. also: listmodes/listoptions (in "lbmk") now reports an error if no scripts and/or directories are found. also: where a warning is given, but not an error, i've gone through in some places and redirected the output to stderr, not stdout as part of error checks: running anything as root, except for the "./build dependencies *" commands, is no longer permitted and lbmk will throw an error mrc downloads: debugfs output no longer redirected to /dev/null, and stderr no longer redirected to stdout. everything is verbose. certain non-error states are also more verbose. for example, patch_rom in blobs/inject will now state when injection succeeds certain actual errors(bugs) were fixed: for example, build/release/roms now correctly prepares the blobs hash files for a given target, containing only the files and checksums in the list. Previously, a printf message was included. Now, with this new code: blobutil/inject rightly verifies hashes. doing all of this in one giant patch is cleaner than 100 patches changing each file. even this is yet part of a much larger audit going on in the Libreboot project. Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'resources/scripts/build/grub/utils')
-rwxr-xr-xresources/scripts/build/grub/utils18
1 files changed, 12 insertions, 6 deletions
diff --git a/resources/scripts/build/grub/utils b/resources/scripts/build/grub/utils
index 3ef78227..f0449ed7 100755
--- a/resources/scripts/build/grub/utils
+++ b/resources/scripts/build/grub/utils
@@ -34,12 +34,18 @@ main()
build_grub()
{
(
- cd grub/ || err "cd"
- [ ! -d Makefile ] || make distclean || err "make-distclean"
- ./bootstrap --gnulib-srcdir=gnulib/ --no-git || err "bootstrap"
- ./autogen.sh || err "autogen"
- ./configure --with-platform=coreboot || err "configure"
- make -j$(nproc) || err "make"
+ cd grub/ || \
+ err "build_grub: cd"
+ [ ! -d Makefile ] || make distclean || \
+ err "build_grub: make-distclean"
+ ./bootstrap --gnulib-srcdir=gnulib/ --no-git || \
+ err "build_grub: gnulib bootstrap"
+ ./autogen.sh || \
+ err "build_grub: autogen.sh"
+ ./configure --with-platform=coreboot || \
+ err "build_grub: autoconf"
+ make -j$(nproc) || \
+ err "build_grub: make"
)
}