diff options
| author | Leah Rowe <leah@libreboot.org> | 2021-11-21 15:57:40 +0000 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2021-11-22 10:03:50 +0000 |
| commit | eed25bd2209a4c9f7c21a15689b5c90bd3757a6c (patch) | |
| tree | e0f7711b5a2f6ffb241f408d59f55fca7fc231c1 /resources/coreboot/default/patches/0013-src-security-tpm-Deal-with-zero-length-tlcl-writes.patch | |
| parent | fd586c8f307d56075b6335920a5d3e13a0c6897b (diff) | |
update coreboot and nuke tianocore20211122
tianocore is a liability for the libreboot project. it's a bloated mess, and
unreliable, broken on many boards, and basically impossible to audit.
i don't trust tianocore, so i'm removing it.
Diffstat (limited to 'resources/coreboot/default/patches/0013-src-security-tpm-Deal-with-zero-length-tlcl-writes.patch')
| -rw-r--r-- | resources/coreboot/default/patches/0013-src-security-tpm-Deal-with-zero-length-tlcl-writes.patch | 36 |
1 files changed, 0 insertions, 36 deletions
diff --git a/resources/coreboot/default/patches/0013-src-security-tpm-Deal-with-zero-length-tlcl-writes.patch b/resources/coreboot/default/patches/0013-src-security-tpm-Deal-with-zero-length-tlcl-writes.patch deleted file mode 100644 index 4f3bff48..00000000 --- a/resources/coreboot/default/patches/0013-src-security-tpm-Deal-with-zero-length-tlcl-writes.patch +++ /dev/null @@ -1,36 +0,0 @@ -From 6c9fe645f8444bd4586e26b545cc9dceb162f03a Mon Sep 17 00:00:00 2001 -From: Patrick Georgi <pgeorgi@google.com> -Date: Wed, 12 May 2021 14:54:49 +0200 -Subject: [PATCH 13/19] src/security/tpm: Deal with zero length tlcl writes - -While memcpy(foo, bar, 0) should be a no-op, that's hard to prove for a -compiler and so gcc 11.1 complains about the use of an uninitialized -"bar" even though it's harmless in this case. - -Change-Id: Idbffa508c2cd68790efbc0b4ab97ae1b4d85ad51 -Signed-off-by: Patrick Georgi <pgeorgi@google.com> -Reviewed-on: https://review.coreboot.org/c/coreboot/+/54095 -Tested-by: build bot (Jenkins) <no-reply@coreboot.org> -Reviewed-by: Jacob Garber <jgarber1@ualberta.ca> -Reviewed-by: Angel Pons <th3fanbus@gmail.com> ---- - src/security/tpm/tss/tcg-1.2/tss.c | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) - -diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c -index 8b7778ddb2..413b68193f 100644 ---- a/src/security/tpm/tss/tcg-1.2/tss.c -+++ b/src/security/tpm/tss/tcg-1.2/tss.c -@@ -215,7 +215,8 @@ uint32_t tlcl_write(uint32_t index, const void *data, uint32_t length) - - to_tpm_uint32(cmd.buffer + tpm_nv_write_cmd.index, index); - to_tpm_uint32(cmd.buffer + tpm_nv_write_cmd.length, length); -- memcpy(cmd.buffer + tpm_nv_write_cmd.data, data, length); -+ if (length > 0) -+ memcpy(cmd.buffer + tpm_nv_write_cmd.data, data, length); - - return tlcl_send_receive(cmd.buffer, response, sizeof(response)); - } --- -2.25.1 - |