summaryrefslogtreecommitdiff
path: root/include/option.sh
diff options
context:
space:
mode:
authorLeah Rowe <leah@libreboot.org>2023-10-02 03:39:10 +0100
committerLeah Rowe <leah@libreboot.org>2023-10-02 03:39:10 +0100
commit7b02bb9aa6e533f30f25133caf9d214ca3d5bda2 (patch)
tree48c632f092a56050308a9478379311b66048c9d5 /include/option.sh
parent8c03b886c4d4b9bcfb1cb30b3704b8af561c2f45 (diff)
do not handle errors on mktemp in shell scripts
errors are not defined for mktemp, and the /tmp file system should be assumed reliable. if /tmp is *unreliable*, then this is not something that lbmk either can or should fix; the user clearly has bigger problems. manpages for mktemp do not define errors. it is assumed to be completely reliable. Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'include/option.sh')
-rwxr-xr-xinclude/option.sh5
1 files changed, 2 insertions, 3 deletions
diff --git a/include/option.sh b/include/option.sh
index 07ef83c8..73a727e4 100755
--- a/include/option.sh
+++ b/include/option.sh
@@ -24,10 +24,9 @@ scan_config()
awkstr=" /\{.*${1}.*}{/ {flag=1;next} /\}/{flag=0} flag { print }"
confdir="${2}"
_fail="${3}"
- revfile="$(mktemp -t sources.XXXXXXXXXX)" || \
- "${_fail}" "scan_config: Cannot initialise tmpfile"
+ revfile="$(mktemp -t sources.XXXXXXXXXX)"
cat "${confdir}/"* > "${revfile}" || \
- "${_fail}" "scan_config: Cannot concatenate files"
+ "${_fail}" "scan_config ${confdir}: Cannot concatenate files"
while read -r line ; do
set ${line} 1>/dev/null 2>/dev/null || :
if [ "${1%:}" = "depend" ]; then