diff options
| author | Leah Rowe <leah@libreboot.org> | 2024-05-21 23:32:18 +0100 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2024-05-21 23:40:25 +0100 |
| commit | e5a5935d8d99dccf66067b5e907d1df81b4a15c4 (patch) | |
| tree | d2343288aac67ff418897937348f3884920d14f5 /config/submodule/coreboot/haswell | |
| parent | a2ac4d13981dcb0aa4e5644a9999e55e32a125ec (diff) | |
fix building coreboot images on i686 hosts
firstly, memtest86+ is currently not cross compiled and
relies on 64-bit headers (x86_64 only). a 32-bit distro
is unlikely to be able to build 64-bit binaries.
secondly: vboot throws a build error due to -Werror when
building on 32-bit hosts. we rely on vboot code to build
cbfstool, so turn off -Werror on vboot
that's all. 32-bit hosts are not recommended; it is assumed
that you are building on an x86_64 host. work will go into
the build system at a later date to make it more portable,
by cross compiling everything, but this should fix 32-bit
for now.
there are some x60/t60 users who still want to build roms,
so let's allow them that possibility.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'config/submodule/coreboot/haswell')
| -rw-r--r-- | config/submodule/coreboot/haswell/vboot/patches/0001-don-t-treat-warnings-as-errors.patch | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/config/submodule/coreboot/haswell/vboot/patches/0001-don-t-treat-warnings-as-errors.patch b/config/submodule/coreboot/haswell/vboot/patches/0001-don-t-treat-warnings-as-errors.patch new file mode 100644 index 00000000..73d796c8 --- /dev/null +++ b/config/submodule/coreboot/haswell/vboot/patches/0001-don-t-treat-warnings-as-errors.patch @@ -0,0 +1,35 @@ +From dd263a01c6f1b63fc12a2a3e96e87a8cee8d987c Mon Sep 17 00:00:00 2001 +From: Leah Rowe <info@minifree.org> +Date: Tue, 21 May 2024 23:21:49 +0100 +Subject: [PATCH 1/1] don't treat warnings as errors + +Signed-off-by: Leah Rowe <info@minifree.org> +--- + Makefile | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/Makefile b/Makefile +index e3739dc0..a11dccbd 100644 +--- a/Makefile ++++ b/Makefile +@@ -112,7 +112,7 @@ endif + # Provide default CC and CFLAGS for firmware builds; if you have any -D flags, + # please add them after this point (e.g., -DVBOOT_DEBUG). + DEBUG_FLAGS := $(if $(filter-out 0,${DEBUG}),-g -Og,-g -Os) +-WERROR := -Werror ++WERROR := -Wno-error -w + FIRMWARE_FLAGS := -nostdinc -ffreestanding -fno-builtin -fno-stack-protector + COMMON_FLAGS := -pipe ${WERROR} -Wall -Wstrict-prototypes -Wtype-limits \ + -Wundef -Wmissing-prototypes -Wno-trigraphs -Wredundant-decls -Wshadow \ +@@ -126,7 +126,7 @@ COMMON_FLAGS := -pipe ${WERROR} -Wall -Wstrict-prototypes -Wtype-limits \ + # returns: $(1) if compiler was successful, empty string otherwise + test_ccflag = $(shell \ + printf "$(2)\nvoid _start(void) {}\n" | \ +- $(CC) -nostdlib -Werror $(1) -xc -c - -o /dev/null \ ++ $(CC) -nostdlib -Wno-error -w $(1) -xc -c - -o /dev/null \ + >/dev/null 2>&1 && echo "$(1)") + + COMMON_FLAGS += $(call test_ccflag,-Wimplicit-fallthrough) +-- +2.39.2 + |