diff options
| author | Leah Rowe <leah@libreboot.org> | 2024-12-02 02:01:09 +0000 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2024-12-02 05:57:34 +0000 |
| commit | c1b73269726a00255aa31ec02b3e55d281b397e6 (patch) | |
| tree | 8be4c5e7aac81b747295334e102659aa2b6ea94f /config/coreboot/next/patches/0010-t480-hack-turn-off-the-dgpu.patch | |
| parent | 264928c6cdefb0b7a3c3ff01d4fe16fa4cc3cbd8 (diff) | |
NEW MAINBOARD: ThinkPad T480S
Added t480s delta to deguard, for MFS config.
Updated coreboot/next to latest t480 patch set,
which includes t480s. This porting was done by
Mate Kukri.
also includes experimental t480s support
Also added a data.vbt file (not in the gerrit patch)
for the T480s.
I had to turn on 8254 legacy timer on t480s, otherwise
SeaBIOS would hang. Same issue I saw on OptiPlex 3050 Micro.
Minor issue:
On S3 resume, nvme0n1 for example got renamed to nvme0n2.
This caused a crash if running Linux from the nvme. I confirmed
this via live USB distro. So this port will need some tweaking
before it can be considered stable.
Also uses libgfxinit, which Mate recently fixed. I'm
going to enable libgfxinit on regular T480 next.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'config/coreboot/next/patches/0010-t480-hack-turn-off-the-dgpu.patch')
| -rw-r--r-- | config/coreboot/next/patches/0010-t480-hack-turn-off-the-dgpu.patch | 45 |
1 files changed, 0 insertions, 45 deletions
diff --git a/config/coreboot/next/patches/0010-t480-hack-turn-off-the-dgpu.patch b/config/coreboot/next/patches/0010-t480-hack-turn-off-the-dgpu.patch deleted file mode 100644 index eaddf398..00000000 --- a/config/coreboot/next/patches/0010-t480-hack-turn-off-the-dgpu.patch +++ /dev/null @@ -1,45 +0,0 @@ -From 7c386cbe38fc42c036bd14b9048b13f1a1d45877 Mon Sep 17 00:00:00 2001 -From: Leah Rowe <info@minifree.org> -Date: Sun, 1 Dec 2024 23:40:08 +0000 -Subject: [PATCH 1/1] t480 hack: turn off the dgpu - -too buggy, in mkukri's testing. just turn it off. - -thanks go to mkukri for showing me how to turn this off. -as nicholas explained to me, if there's no nvram on this board, -coreboot can't use a static option table, because that works by -copying those settings to the nvram. - -so we just have to hardcode for the time being - -Signed-off-by: Leah Rowe <info@minifree.org> ---- - 3rdparty/vboot | 2 +- - src/mainboard/lenovo/sklkbl_thinkpad/ramstage.c | 4 +++- - 2 files changed, 4 insertions(+), 2 deletions(-) - -diff --git a/3rdparty/vboot b/3rdparty/vboot -index f1f70f46dc..1f53ea9b7f 160000 ---- a/3rdparty/vboot -+++ b/3rdparty/vboot -@@ -1 +1 @@ --Subproject commit f1f70f46dc5482bb7c654e53ed58d4001e386df2 -+Subproject commit 1f53ea9b7f398884f722fca046129eae5ea6a71c -diff --git a/src/mainboard/lenovo/sklkbl_thinkpad/ramstage.c b/src/mainboard/lenovo/sklkbl_thinkpad/ramstage.c -index 9526642c57..bf5da12689 100644 ---- a/src/mainboard/lenovo/sklkbl_thinkpad/ramstage.c -+++ b/src/mainboard/lenovo/sklkbl_thinkpad/ramstage.c -@@ -31,7 +31,9 @@ void mainboard_silicon_init_params(FSP_SIL_UPD *params) - dgfx_vram_id = gpio_get(GPIO_DGFX_VRAM_ID0) | gpio_get(GPIO_DGFX_VRAM_ID1) << 1; - printk(BIOS_DEBUG, "Discrete GPU present with %s VRAM\n", dgfx_vram_id_str[dgfx_vram_id]); - -- if (get_uint_option("dgpu_enable", 1)) { -+// if (get_uint_option("dgpu_enable", 1)) { -+ if (get_uint_option("dgpu_enable", 0)) { // HACK: no option table due to no nvram. -+ // (turn off the dgpu by default due to bugs) - printk(BIOS_DEBUG, "Enabling discrete GPU\n"); - // NOTE: i pulled this GPU enable sequence from thin air but it seems to work - gpio_set(GPIO_1R8VIDEO_AON_ON, 1); // Enable GPU power rail --- -2.39.5 - |