diff options
| author | Leah Rowe <leah@libreboot.org> | 2024-01-25 18:39:19 +0000 |
|---|---|---|
| committer | Leah Rowe <leah@libreboot.org> | 2024-01-25 18:57:07 +0000 |
| commit | 0a24b2e612e5dbd5edabc5ce2001dd92f47b9776 (patch) | |
| tree | 92c419890fcb7cc204fbd3587f859e2a4c5c2af2 /config/coreboot/e6430_12mb | |
| parent | 614c5efa6550a0c1935965848a2b86382bf6c67a (diff) | |
dell/e6*30: use generic PS2K/PS2M EISAID strings
CONFIG_PS2M_EISAID. this is a a string used for the
identifier on the mouse, in ACPI.
CONFIG_PS2K_EISAID this is used for the keyboard.
IASL comes back with this build error:
dsdt.asl 1884: Name(_HID, EISAID("DLLK0534"))
Error 6045 - ^ EISAID string must be of the form "UUUXXXX" (3 uppercase, 4 hex digits) (DLLK0534)
Change DLLK0534 back to PNP0303 and
change DLL0534 back to PNP0F13. These are generic identifiers
for PS/2 keyboard and mouse. Any generic driver will work with
the onboard mouse/keyboard on these machines. They do not need
to be changed. These are the default values anyway. Just leave
them explicitly defined to the default values, for now; if these
options are not set, coreboot will default to these values.
This shouldn't break anything for the users. I've reported this
to Nicholas Chin, author of those patches. Libreboot imported
the new versions of E6430/E6530 board patches in the coreboot
revision update, but the new (technically correct) values broke
IASL, so I've decided to use the old values for now.
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'config/coreboot/e6430_12mb')
| -rw-r--r-- | config/coreboot/e6430_12mb/config/libgfxinit_corebootfb | 4 | ||||
| -rw-r--r-- | config/coreboot/e6430_12mb/config/libgfxinit_txtmode | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/config/coreboot/e6430_12mb/config/libgfxinit_corebootfb b/config/coreboot/e6430_12mb/config/libgfxinit_corebootfb index 8416f2ef..3254c612 100644 --- a/config/coreboot/e6430_12mb/config/libgfxinit_corebootfb +++ b/config/coreboot/e6430_12mb/config/libgfxinit_corebootfb @@ -139,8 +139,8 @@ CONFIG_BOARD_DELL_LATITUDE_E6430=y # CONFIG_BOARD_DELL_LATITUDE_E6530 is not set # CONFIG_BOARD_DELL_OPTIPLEX_9010 is not set # CONFIG_BOARD_DELL_PRECISION_T1650 is not set -CONFIG_PS2K_EISAID="DLLK0534" -CONFIG_PS2M_EISAID="DLL0534" +CONFIG_PS2K_EISAID="PNP0303" +CONFIG_PS2M_EISAID="PNP0F13" CONFIG_ECAM_MMCONF_BASE_ADDRESS=0xf0000000 CONFIG_ECAM_MMCONF_BUS_NUMBER=64 CONFIG_MEMLAYOUT_LD_FILE="src/arch/x86/memlayout.ld" diff --git a/config/coreboot/e6430_12mb/config/libgfxinit_txtmode b/config/coreboot/e6430_12mb/config/libgfxinit_txtmode index 4614c7fd..c76f2a2f 100644 --- a/config/coreboot/e6430_12mb/config/libgfxinit_txtmode +++ b/config/coreboot/e6430_12mb/config/libgfxinit_txtmode @@ -137,8 +137,8 @@ CONFIG_BOARD_DELL_LATITUDE_E6430=y # CONFIG_BOARD_DELL_LATITUDE_E6530 is not set # CONFIG_BOARD_DELL_OPTIPLEX_9010 is not set # CONFIG_BOARD_DELL_PRECISION_T1650 is not set -CONFIG_PS2K_EISAID="DLLK0534" -CONFIG_PS2M_EISAID="DLL0534" +CONFIG_PS2K_EISAID="PNP0303" +CONFIG_PS2M_EISAID="PNP0F13" CONFIG_ECAM_MMCONF_BASE_ADDRESS=0xf0000000 CONFIG_ECAM_MMCONF_BUS_NUMBER=64 CONFIG_MEMLAYOUT_LD_FILE="src/arch/x86/memlayout.ld" |