diff options
author | Leah Rowe <leah@libreboot.org> | 2023-08-23 19:56:01 +0100 |
---|---|---|
committer | Leah Rowe <leah@libreboot.org> | 2023-08-23 21:34:02 +0100 |
commit | 4c6c7d1088eb9dc0c9b2eeeb64febeeb78038583 (patch) | |
tree | 1966a4f85069b3dd3e214d9724dcc0f059d1e6de /blobs/hp_sandybridge | |
parent | 52f3fd359e04caf9dd7bc89889dfc326f5ae9352 (diff) |
scripts: never exit 1, always call err instead
this same change has been applied, selectively, to
certain return statements. the general rule is this:
the return statement should only be used to direct
logic within a script, where certain non-errors
states are used to skip certain actions; the exit
command should *never* be used to return non-zero,
except by err(). in so doing, we ensure easier
debugging of the build system
also: strip_rom_image in build/release/roms was
running "continue" when a rom file didn't exist,
despite not being a while/for loop. i make it
return (non-error condition) instead
it's ok for a script to exit 0, where appropriate,
but perhaps a function could also be written for it
Signed-off-by: Leah Rowe <leah@libreboot.org>
Diffstat (limited to 'blobs/hp_sandybridge')
0 files changed, 0 insertions, 0 deletions