diff options
author | Leah Rowe <leah@libreboot.org> | 2022-12-01 13:16:05 +0000 |
---|---|---|
committer | Leah Rowe <leah@libreboot.org> | 2022-12-01 13:16:05 +0000 |
commit | 85937f3f4c3f53b281b6a2f453e2273217e42aa1 (patch) | |
tree | c863ffb884533f693dd177951c98b3d1a9a03567 | |
parent | ec082429ab35a45d8a362703c26932206b5b1747 (diff) |
util/nvmutil: reset errno on cmd_swap
If one of the checksums was valid, but the other was not,
errno would be set to E_CANCELED, but then the buffer would
be modified anyway; this is acceptable behaviour, and errno
would later be reset writing the GBE file, which is done
only on the condition that the buffer was modified, but
it's also a good idea to reset it here just in case.
This is not a bugfix, and no behavioural changes will be
observed by the user, but this may *prevent* a bug in the
future, so let's pre-fix that bug now.
-rw-r--r-- | util/nvmutil/nvmutil.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index 02f62304..5a28a9a7 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -345,6 +345,7 @@ cmd_swap(void) gbeFileModified = 1; nvmPartModified[0] = 1; nvmPartModified[1] = 1; + errno = 0; } } |