From 0cf2eee19eef5270410d054cf8e26a8be99245a8 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sun, 4 Dec 2022 22:35:01 +0000 Subject: [PATCH 17/17] util/ifdtool: add --nuke flag (all 0xFF on region) When this option is used, the region's contents are overwritten with all ones (0xFF). Example: ./ifdtool --nuke gbe coreboot.rom ./ifdtool --nuke bios coreboot.com ./ifdtool --nuke me coreboot.com --- util/ifdtool/ifdtool.c | 98 ++++++++++++++++++++++++++++++++---------- 1 file changed, 76 insertions(+), 22 deletions(-) diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index ca5d3b8d21..8ba1335772 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1640,19 +1640,68 @@ static void print_usage(const char *name) " tgl - Tiger Lake\n" " -S | --setpchstrap Write a PCH strap\n" " -V | --newvalue The new value to write into PCH strap specified by -S\n" + " -N | --nuke Overwrite the specified region with 0xFF (all ones)\n" " -v | --version: print the version\n" " -h | --help: print this help\n\n" " is one of Descriptor, BIOS, ME, GbE, Platform, res1, res2, res3\n" "\n"); } +static int +get_region_type_string(const char *region_type_string) +{ + if (region_type_string == NULL) + return -1; + else if (!strcasecmp("Descriptor", region_type_string)) + return 0; + else if (!strcasecmp("BIOS", region_type_string)) + return 1; + else if (!strcasecmp("ME", region_type_string)) + return 2; + else if (!strcasecmp("GbE", region_type_string)) + return 3; + else if (!strcasecmp("Platform", region_type_string)) + return 4; + else if (!strcasecmp("res1", region_type_string)) + return 5; + else if (!strcasecmp("res2", region_type_string)) + return 6; + else if (!strcasecmp("res3", region_type_string)) + return 7; + else if (!strcasecmp("EC", region_type_string)) + return 8; + else + return -1; +} + + +static void +nuke(const char *filename, char *image, int size, int region_type) +{ + int i; + region_t region; + const frba_t *frba = find_frba(image, size); + if (!frba) + exit(EXIT_FAILURE); + + region = get_region(frba, region_type); + if (region.size > 0) { + for (i = region.base; i <= region.limit; i++) { + if ((i + 1) > (size)) + break; + image[i] = 0xFF; + } + write_image(filename, image, size); + } +} + int main(int argc, char *argv[]) { int opt, option_index = 0; int mode_dump = 0, mode_extract = 0, mode_inject = 0, mode_spifreq = 0; int mode_em100 = 0, mode_locked = 0, mode_unlocked = 0, mode_validate = 0; int mode_layout = 0, mode_newlayout = 0, mode_density = 0, mode_setstrap = 0; - int mode_read = 0, mode_altmedisable = 0, altmedisable = 0; + int mode_read = 0, mode_altmedisable = 0, altmedisable = 0, mode_nuke = 0; char *region_type_string = NULL, *region_fname = NULL; const char *layout_fname = NULL; char *new_filename = NULL; @@ -1683,6 +1732,7 @@ int main(int argc, char *argv[]) {"validate", 0, NULL, 't'}, {"setpchstrap", 1, NULL, 'S'}, {"newvalue", 1, NULL, 'V'}, + {"nuke", 1, NULL, 'N'}, {0, 0, 0, 0} }; @@ -1723,25 +1773,8 @@ int main(int argc, char *argv[]) region_fname++; // Descriptor, BIOS, ME, GbE, Platform // valid type? - if (!strcasecmp("Descriptor", region_type_string)) - region_type = 0; - else if (!strcasecmp("BIOS", region_type_string)) - region_type = 1; - else if (!strcasecmp("ME", region_type_string)) - region_type = 2; - else if (!strcasecmp("GbE", region_type_string)) - region_type = 3; - else if (!strcasecmp("Platform", region_type_string)) - region_type = 4; - else if (!strcasecmp("res1", region_type_string)) - region_type = 5; - else if (!strcasecmp("res2", region_type_string)) - region_type = 6; - else if (!strcasecmp("res3", region_type_string)) - region_type = 7; - else if (!strcasecmp("EC", region_type_string)) - region_type = 8; - if (region_type == -1) { + if ((region_type = + get_region_type_string(region_type_string)) == -1) { fprintf(stderr, "No such region type: '%s'\n\n", region_type_string); print_usage(argv[0]); @@ -1900,6 +1933,22 @@ int main(int argc, char *argv[]) case 't': mode_validate = 1; break; + case 'N': + region_type_string = strdup(optarg); + if (!region_type_string) { + fprintf(stderr, "No region specified\n"); + print_usage(argv[0]); + exit(EXIT_FAILURE); + } + if ((region_type = + get_region_type_string(region_type_string)) == -1) { + fprintf(stderr, "No such region type: '%s'\n\n", + region_type_string); + print_usage(argv[0]); + exit(EXIT_FAILURE); + } + mode_nuke = 1; + break; case 'v': print_version(); exit(EXIT_SUCCESS); @@ -1915,7 +1964,7 @@ int main(int argc, char *argv[]) if ((mode_dump + mode_layout + mode_extract + mode_inject + mode_setstrap + mode_newlayout + (mode_spifreq | mode_em100 | mode_unlocked | - mode_locked) + mode_altmedisable + mode_validate) > 1) { + mode_locked) + mode_altmedisable + mode_validate + mode_nuke) > 1) { fprintf(stderr, "You may not specify more than one mode.\n\n"); print_usage(argv[0]); exit(EXIT_FAILURE); @@ -1923,7 +1972,8 @@ int main(int argc, char *argv[]) if ((mode_dump + mode_layout + mode_extract + mode_inject + mode_setstrap + mode_newlayout + mode_spifreq + mode_em100 + mode_locked + - mode_unlocked + mode_density + mode_altmedisable + mode_validate) == 0) { + mode_unlocked + mode_density + mode_altmedisable + mode_validate + + mode_nuke) == 0) { fprintf(stderr, "You need to specify a mode.\n\n"); print_usage(argv[0]); exit(EXIT_FAILURE); @@ -2021,6 +2071,10 @@ int main(int argc, char *argv[]) write_image(new_filename, image, size); } + if (mode_nuke) { + nuke(new_filename, image, size, region_type); + } + if (mode_altmedisable) { fpsba_t *fpsba = find_fpsba(image, size); fmsba_t *fmsba = find_fmsba(image, size); -- 2.25.1