From 4739f197ee3d4c95809ba48671bc5c409766b9c7 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Wed, 11 Dec 2024 01:06:01 +0000 Subject: [PATCH 28/41] dell/3050micro: disable nvme hotplug in my testing, when running my 3050micro for a few days, the nvme would sometimes randomly rename. e.g. nvme0n1 renamed to nvme0n2 this might cause crashes in linux, if booting only from the nvme. in my case, i was booting from mdraid (sata+nvme) and every few days, the nvme would rename at least once, causing my RAID to become unsynced. since i'm using RAID1, this was OK and I could simply re-sync the array, but this is quite precarious indeed. if you're using raid0, that will potentially corrupt your RAID array indefinitely. this same issue manifested on the T480/T480 thinkpads, and S3 resume would break because of that, when booting from nvme, because the nvme would be "unplugged" and appear to linux as a new device (the one that you booted from). the fix there was to disable hotplugging on that pci-e slot for the nvme, so apply the same fix here for 3050 micro Signed-off-by: Leah Rowe --- .../dell/sklkbl_desktops/variants/optiplex_3050/overridetree.cb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/dell/sklkbl_desktops/variants/optiplex_3050/overridetree.cb b/src/mainboard/dell/sklkbl_desktops/variants/optiplex_3050/overridetree.cb index c5f1749b2c..ff48a8121a 100644 --- a/src/mainboard/dell/sklkbl_desktops/variants/optiplex_3050/overridetree.cb +++ b/src/mainboard/dell/sklkbl_desktops/variants/optiplex_3050/overridetree.cb @@ -46,7 +46,7 @@ chip soc/intel/skylake register "PcieRpAdvancedErrorReporting[20]" = "1" register "PcieRpLtrEnable[20]" = "true" register "PcieRpClkSrcNumber[20]" = "3" - register "PcieRpHotPlug[20]" = "1" + register "PcieRpHotPlug[20]" = "0" end end -- 2.47.3