From c48a962eaf4d2033465a01c83c98caeca7b5a5fd Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Wed, 1 Apr 2026 17:27:18 +0100 Subject: lbutils/file: fix overflow check clang -Weverything: lib/file.c:165:49: warning: implicit conversion changes signedness: 'ssize_t' (aka 'long') to 'size_t' (aka 'unsigned long') [-Wsign-conversion] 165 | if (if_err(rval >= 0 && (size_t)rval > (nrw - rc), EOVERFLOW)) Signed-off-by: Leah Rowe --- util/libreboot-utils/lib/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'util') diff --git a/util/libreboot-utils/lib/file.c b/util/libreboot-utils/lib/file.c index 883d4cd4..3ec39239 100644 --- a/util/libreboot-utils/lib/file.c +++ b/util/libreboot-utils/lib/file.c @@ -158,7 +158,8 @@ rw_exact(int fd, unsigned char *mem, size_t nrw, while (1) { /* Prevent theoretical overflow */ - if (if_err(rval >= 0 && (size_t)rval > (nrw - rc), EOVERFLOW)) + if (if_err(rval >= 0 && (size_t)rval > (nrw - (size_t)rc), + EOVERFLOW)) goto err_rw_exact; rc += rval; -- cgit v1.2.1