From 947211fc3c13412e3f65d17fef240989fda39b23 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Wed, 4 Mar 2026 02:06:33 +0000 Subject: util/nvmutil: tidy up cmd_brick Signed-off-by: Leah Rowe --- util/nvmutil/nvmutil.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) (limited to 'util') diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index 9e4f4d01..dabf8e83 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -547,11 +547,20 @@ cmd_setchecksum(void) static void cmd_brick(void) { - if (!good_checksum(part)) - err(ECANCELED, "brick p%d, file '%s'", part, fname); + uint16_t checksum_word; - set_word(NVM_CHECKSUM_WORD, part, - ((word(NVM_CHECKSUM_WORD, part)) ^ 0xFF)); + if (!good_checksum(part)) { + err(ECANCELED, + "Part %d checksum already invalid in file '%s'", + part, fname); + } + + /* + * We know checksum_word is valid, so we need only + * flip one bit to invalidate it. + */ + checksum_word = word(NVM_CHECKSUM_WORD, part); + set_word(NVM_CHECKSUM_WORD, part, checksum_word ^ 1); } static void -- cgit v1.2.1