From 05f59ac7c62b15f61f191cb4a7022f44667f2f5f Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Fri, 13 Mar 2026 01:42:41 +0000 Subject: spkmodem-decode: enforce calibrated seperator range we weren't actually using what we calculated. this patch fixes that, thus preventing random noise / microphone clicks, random artifacts and such from being treated as real frames (the purpose of is_valid_signal is partly noise suppression). Signed-off-by: Leah Rowe --- util/spkmodem_decode/spkmodem-decode.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'util/spkmodem_decode') diff --git a/util/spkmodem_decode/spkmodem-decode.c b/util/spkmodem_decode/spkmodem-decode.c index 36b424b8..af60f997 100644 --- a/util/spkmodem_decode/spkmodem-decode.c +++ b/util/spkmodem_decode/spkmodem-decode.c @@ -386,8 +386,14 @@ select_separator_tone(struct decoder_state *st) static int is_valid_signal(struct decoder_state *st) { - return (st->freq_separator > 0 && - st->freq_data > 0); + if (st->freq_data <= 0) + return 0; + + if (st->freq_separator < st->sep_min || + st->freq_separator > st->sep_max) + return 0; + + return 1; } /* -- cgit v1.2.1